Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1876)

Unified Diff: chrome/browser/history/history.cc

Issue 10802066: Adds support for saving favicon size into history database. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Created 8 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « chrome/browser/history/history.h ('k') | chrome/browser/history/history_backend.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/browser/history/history.cc
diff --git a/chrome/browser/history/history.cc b/chrome/browser/history/history.cc
index 648de2963dd020abb15ab4cbc4f21a08d057b0e6..5c2f934177a1c0dcb7ed76a29a6d2b637392f0b5 100644
--- a/chrome/browser/history/history.cc
+++ b/chrome/browser/history/history.cc
@@ -491,58 +491,66 @@ HistoryService::Handle HistoryService::GetPageThumbnail(
new history::GetPageThumbnailRequest(callback), page_url);
}
-void HistoryService::GetFavicon(FaviconService::GetFaviconRequest* request,
- const GURL& icon_url,
- history::IconType icon_type) {
- Schedule(PRIORITY_NORMAL, &HistoryBackend::GetFavicon, NULL, request,
- icon_url, icon_type);
-}
-
-void HistoryService::UpdateFaviconMappingAndFetch(
+void HistoryService::GetFavicons(
FaviconService::GetFaviconRequest* request,
- const GURL& page_url,
- const GURL& icon_url,
- history::IconType icon_type) {
- Schedule(PRIORITY_NORMAL, &HistoryBackend::UpdateFaviconMappingAndFetch, NULL,
- request, page_url, icon_url, history::FAVICON);
+ const std::vector<GURL>& icon_urls,
+ int icon_types,
+ int desired_size_in_dip,
+ const std::vector<ui::ScaleFactor>& desired_scale_factors) {
+ Schedule(PRIORITY_NORMAL, &HistoryBackend::GetFavicons, NULL, request,
+ icon_urls, icon_types, desired_size_in_dip, desired_scale_factors);
}
-void HistoryService::GetFaviconForURL(
+void HistoryService::GetFaviconsForURL(
FaviconService::GetFaviconRequest* request,
const GURL& page_url,
- int icon_types) {
- Schedule(PRIORITY_NORMAL, &HistoryBackend::GetFaviconForURL, NULL, request,
- page_url, icon_types);
+ int icon_types,
+ int desired_size_in_dip,
+ const std::vector<ui::ScaleFactor>& desired_scale_factors) {
+ Schedule(PRIORITY_NORMAL, &HistoryBackend::GetFaviconsForURL, NULL, request,
+ page_url, icon_types, desired_size_in_dip, desired_scale_factors);
}
void HistoryService::GetFaviconForID(FaviconService::GetFaviconRequest* request,
- history::FaviconID id) {
+ history::FaviconID favicon_id,
+ int desired_size_in_dip,
+ ui::ScaleFactor desired_scale_factor) {
Schedule(PRIORITY_NORMAL, &HistoryBackend::GetFaviconForID, NULL, request,
- id);
+ favicon_id, desired_size_in_dip, desired_scale_factor);
+}
+
+void HistoryService::UpdateFaviconMappingsAndFetch(
+ FaviconService::GetFaviconRequest* request,
+ const GURL& page_url,
+ const std::vector<GURL>& icon_urls,
+ int icon_types,
+ int desired_size_in_dip,
+ const std::vector<ui::ScaleFactor>& desired_scale_factors) {
+ Schedule(PRIORITY_NORMAL, &HistoryBackend::UpdateFaviconMappingsAndFetch,
+ NULL, request, page_url, icon_urls, icon_types, desired_size_in_dip,
+ desired_scale_factors);
}
-void HistoryService::SetFavicon(const GURL& page_url,
- const GURL& icon_url,
- const std::vector<unsigned char>& image_data,
- history::IconType icon_type) {
+void HistoryService::SetFavicons(
+ const GURL& page_url,
+ history::IconType icon_type,
+ const std::vector<history::FaviconBitmapData>& favicon_bitmap_data,
+ const history::IconURLSizesMap& icon_url_sizes) {
if (!CanAddURL(page_url))
return;
- ScheduleAndForget(PRIORITY_NORMAL, &HistoryBackend::SetFavicon,
- page_url, icon_url,
- scoped_refptr<base::RefCountedMemory>(
- new base::RefCountedBytes(image_data)),
- icon_type);
+ ScheduleAndForget(PRIORITY_NORMAL, &HistoryBackend::SetFavicons, page_url,
+ icon_type, favicon_bitmap_data, icon_url_sizes);
}
-void HistoryService::SetFaviconOutOfDateForPage(const GURL& page_url) {
+void HistoryService::SetFaviconsOutOfDateForPage(const GURL& page_url) {
ScheduleAndForget(PRIORITY_NORMAL,
- &HistoryBackend::SetFaviconOutOfDateForPage, page_url);
+ &HistoryBackend::SetFaviconsOutOfDateForPage, page_url);
}
-void HistoryService::CloneFavicon(const GURL& old_page_url,
+void HistoryService::CloneFavicons(const GURL& old_page_url,
const GURL& new_page_url) {
- ScheduleAndForget(PRIORITY_NORMAL, &HistoryBackend::CloneFavicon,
+ ScheduleAndForget(PRIORITY_NORMAL, &HistoryBackend::CloneFavicons,
old_page_url, new_page_url);
}
« no previous file with comments | « chrome/browser/history/history.h ('k') | chrome/browser/history/history_backend.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698