Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1780)

Unified Diff: chrome/browser/favicon/select_favicon_frames.h

Issue 10802066: Adds support for saving favicon size into history database. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Changes as requested Created 8 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/favicon/select_favicon_frames.h
diff --git a/chrome/browser/favicon/select_favicon_frames.h b/chrome/browser/favicon/select_favicon_frames.h
index 768d394653caa5568c998be716f09be145824932..46940d9c398f4940aaaad225ab80a24fe29551da 100644
--- a/chrome/browser/favicon/select_favicon_frames.h
+++ b/chrome/browser/favicon/select_favicon_frames.h
@@ -7,6 +7,7 @@
#include <vector>
+#include "chrome/browser/history/history_types.h"
#include "ui/base/layout.h"
class SkBitmap;
@@ -16,10 +17,10 @@ class ImageSkia;
}
// Takes a list of all bitmaps found in a .ico file, and creates an
-// ImageSkia that's desired_size x desired_size pixels big. This
+// ImageSkia that's |desired_size| x |desired_size| DIP big. This
// function adds a representation at every desired scale factor.
// If desired_size is 0, the largest bitmap is returned unmodified.
-// If score is non-NULL, it receive a score between 0 (bad) and 1 (good)
+// If score is non-NULL, it receives a score between 0 (bad) and 1 (good)
// that describes how well |bitmaps| were able to produce an image at
// |desired_size| for |scale_factors|.
// The score is arbitrary, but it's best for exact size matches,
@@ -30,4 +31,22 @@ gfx::ImageSkia SelectFaviconFrames(
int desired_size,
float* score);
+// Takes a list of all history::FaviconBitmapIDSize for a favicon and returns
+// the FaviconBitmapIDs (in |filtered_favicon_bitmap_ids|) whose bitmap data
+// should be fetched in order to create an ImageSkia that's |desired_size| x
+// |desired_size| DIP big.
+// If desired_size is 0, the FaviconBitmapID with the largest size is returned.
+// If score is non-NULL, it receives a score between 0 (bad) and 1 (good)
+// that describes how well |filtered_favicon_bitmap_ids| will produce an image
+// at |desired_size| for |scale_factors|.
+// The score is arbitrary, but it's best for exact size matches,
+// and gets worse the more resampling needs to happen.
+// TODO(pkotwicz): Remove need to pass in |scale_factors|.
+void SelectFaviconBitmapIDs(
+ const std::vector<history::FaviconBitmapIDSize>& bitmap_id_sizes,
+ const std::vector<ui::ScaleFactor>& scale_factors,
+ int desired_size,
+ std::vector<history::FaviconBitmapID>* filtered_favicon_bitmap_ids,
+ float* score);
+
#endif // CHROME_BROWSER_FAVICON_SELECT_FAVICON_FRAMES_H_

Powered by Google App Engine
This is Rietveld 408576698