Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2875)

Unified Diff: chrome/browser/history/android/android_provider_backend.cc

Issue 10802066: Adds support for saving favicon size into history database. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Created 8 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/history/android/android_provider_backend.cc
diff --git a/chrome/browser/history/android/android_provider_backend.cc b/chrome/browser/history/android/android_provider_backend.cc
index 60ed1e3bf5d5a7c398a76b08ca9f0facd9945c9d..53bbef34acfb9321e1abeb306a2d5293ba159857 100644
--- a/chrome/browser/history/android/android_provider_backend.cc
+++ b/chrome/browser/history/android/android_provider_backend.cc
@@ -966,11 +966,13 @@ bool AndroidProviderBackend::SimulateUpdateURL(
FaviconID favicon_id = statement->statement()->ColumnInt64(4);
if (favicon_id) {
- scoped_refptr<base::RefCountedMemory> favicon;
- if (!thumbnail_db_->GetFavicon(favicon_id, NULL, &favicon, NULL, NULL))
+ std::vector<FaviconBitmap> favicon_bitmaps;
+ if (!thumbnail_db_->GetFaviconBitmaps(favicon_id, &favicon_bitmaps))
return false;
- if (favicon.get() && favicon->size())
- new_row.set_favicon(favicon);
+ scoped_refptr<base::RefCountedMemory> bitmap_data =
+ favicon_bitmaps[0].bitmap_data;
+ if (bitmap_data.get() && bitmap_data->size())
+ new_row.set_favicon(bitmap_data);
favicon_details->urls.insert(old_url_row.url());
favicon_details->urls.insert(row.url());
}

Powered by Google App Engine
This is Rietveld 408576698