Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(4359)

Unified Diff: chrome/browser/ui/webui/extensions/extension_icon_source.cc

Issue 10802066: Adds support for saving favicon size into history database. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Changes as requested by Sky and stevenjb Created 8 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/ui/webui/extensions/extension_icon_source.cc
diff --git a/chrome/browser/ui/webui/extensions/extension_icon_source.cc b/chrome/browser/ui/webui/extensions/extension_icon_source.cc
index e257097e5dc217cee4f82dda35892f3f162b63d0..f0c689e37379bcbfbf96144c608ba09dca6d483f 100644
--- a/chrome/browser/ui/webui/extensions/extension_icon_source.cc
+++ b/chrome/browser/ui/webui/extensions/extension_icon_source.cc
@@ -222,25 +222,26 @@ void ExtensionIconSource::LoadFaviconImage(int request_id) {
void ExtensionIconSource::OnFaviconDataAvailable(
FaviconService::Handle request_handle,
- history::FaviconData favicon) {
+ history::FaviconData favicon_data) {
int request_id = cancelable_consumer_.GetClientData(
profile_->GetFaviconService(Profile::EXPLICIT_ACCESS), request_handle);
ExtensionIconRequest* request = GetData(request_id);
// Fallback to the default icon if there wasn't a favicon.
- if (!favicon.is_valid()) {
+ if (!favicon_data.is_valid()) {
LoadDefaultImage(request_id);
return;
}
+ history::FaviconDataElement element = favicon_data.elements[0];
if (!request->grayscale) {
// If we don't need a grayscale image, then we can bypass FinalizeImage
// to avoid unnecessary conversions.
ClearData(request_id);
- SendResponse(request_id, favicon.image_data);
+ SendResponse(request_id, element.bitmap_data);
} else {
- FinalizeImage(ToBitmap(favicon.image_data->front(),
- favicon.image_data->size()), request_id);
+ FinalizeImage(ToBitmap(element.bitmap_data->front(),
+ element.bitmap_data->size()), request_id);
}
}

Powered by Google App Engine
This is Rietveld 408576698