Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(984)

Unified Diff: chrome/browser/history/history_types_unittest.cc

Issue 10802066: Adds support for saving favicon size into history database. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Changes as requested by Sky and stevenjb Created 8 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/history/history_types_unittest.cc
diff --git a/chrome/browser/history/history_types_unittest.cc b/chrome/browser/history/history_types_unittest.cc
index b71e85597fbb2c1b0dd7745d38a22159af62392c..1aa39fb73e8a2ded13d3afcafc5204e0b3fa60bd 100644
--- a/chrome/browser/history/history_types_unittest.cc
+++ b/chrome/browser/history/history_types_unittest.cc
@@ -195,4 +195,23 @@ TEST(HistoryQueryResult, RowSignificance) {
EXPECT_FALSE(RowQualifiesAsSignificant(url_row, base::Time()));
}
+TEST(FaviconSizes, ConversionToAndFromString) {
+ // Invalid input.
+ FaviconSizes sizes_missing_height("0 0 10");
+ EXPECT_EQ(0u, sizes_missing_height.num_sizes());
+
+ FaviconSizes sizes_non_int("0 0 a 10");
+ EXPECT_EQ(0u, sizes_missing_height.num_sizes());
+
+ // Valid input.
+ FaviconSizes sizes_valid("10 15 20 25");
+ EXPECT_EQ(2u, sizes_valid.num_sizes());
+ EXPECT_TRUE(sizes_valid.has_size(gfx::Size(10, 15)));
+ EXPECT_TRUE(sizes_valid.has_size(gfx::Size(20, 25)));
+
+ std::string sizes_as_string = sizes_valid.ToString();
+ EXPECT_TRUE(sizes_as_string.compare("10 15 20 25") == 0 ||
+ sizes_as_string.compare("20 25 10 15") == 0);
+}
+
} // namespace

Powered by Google App Engine
This is Rietveld 408576698