Adds support for saving favicon size into history database.

chrome/browser/history/android/android_history_types.h

Index: chrome/browser/history/android/android_history_types.h
diff --git a/chrome/browser/history/android/android_history_types.h b/chrome/browser/history/android/android_history_types.h
index ea56399a10994d57140f85bc77416efdfa3b7e5a..c35be55205ec9f687c3d9c0764c8490bbd6f1836 100644
--- a/chrome/browser/history/android/android_history_types.h
+++ b/chrome/browser/history/android/android_history_types.h
@@ -117,11 +117,11 @@ class HistoryAndBookmarkRow {
   }
 
   // The favicon related to page if any.
-  void set_favicon(const std::vector<unsigned char>& data) {
+  void set_favicon(scoped_refptr<base::RefCountedMemory> data) {

[stevenjb, 2012/08/15 22:59:18]

Shouldn't the arg be a reference to avoid an extra copy?

     set_value_explicitly(FAVICON);
     favicon_ = data;
   }
-  const std::vector<unsigned char>& favicon() const {
+  const scoped_refptr<base::RefCountedMemory> favicon() const {
     return favicon_;

[stevenjb, 2012/08/15 22:59:18]

Same here?

   }
 
@@ -168,7 +168,7 @@ class HistoryAndBookmarkRow {
   string16 title_;
   base::Time created_;
   base::Time last_visit_time_;
-  std::vector<unsigned char> favicon_;
+  scoped_refptr<base::RefCountedMemory> favicon_;
   int visit_count_;
   bool is_bookmark_;
   int64 parent_id_;