Switch default filename retrieval to use GetFielNameToReportUser, which is more authoritative.

chrome/browser/download/chrome_download_manager_delegate.cc

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "chrome/browser/download/chrome_download_manager_delegate.h"
 
 #include <string>
 
 #include "base/bind.h"
 #include "base/bind_helpers.h"
@@ skipping 366 matching lines @@
       item->GetFullPath(),
       item->GetReceivedBytes());
 
   // RCH specifies that the receiver gets the url, but with Web Intents
   // it isn't really needed.
   intent_data.extra_data.insert(make_pair(
       ASCIIToUTF16("url"), ASCIIToUTF16(item->GetURL().spec())));
 
   // The SuggestedFilename is not always filled in in the DownloadItem.
   // When it is, it comes from the purpose-built HTML algorithm, but
-  // in practice it is frequently just inferred.
-  string16 filename = UTF8ToUTF16(item->GetSuggestedFilename());
+  // in practice it is frequently just inferred. GetFileNameToReportUser
+  // is more authoritative.
+  string16 filename = item->GetFileNameToReportUser().LossyDisplayName();

[Greg Billock, 2012/07/23 21:42:22]

So this looks right, then, and is what we decided to use in the discussion?
Shall I just remove the GetSuggestedFilename call as superfluous?

[asanka, 2012/07/23 21:45:43]

Yes. GetFileNameToReportUser() is what we decided to use.

And you can get rid of the GetSuggestedFilename() call.

[Greg Billock, 2012/07/24 20:09:47]

Done.

   if (filename.empty())
-    filename = item->GetFileNameToReportUser().LossyDisplayName();
+    filename = UTF8ToUTF16(item->GetSuggestedFilename());
   intent_data.extra_data.insert(make_pair(ASCIIToUTF16("filename"), filename));
 
   content::WebIntentsDispatcher* dispatcher =
       content::WebIntentsDispatcher::Create(intent_data);
   // TODO(gbillock): try to get this to be able to delegate to the Browser
   // object directly, passing a NULL WebContents?
   item->GetWebContents()->GetDelegate()->WebIntentDispatch(
       item->GetWebContents(), dispatcher);
 }
 
@@ skipping 357 matching lines @@
     int32 download_id, int64 db_handle) {
   // It's not immediately obvious, but HistoryBackend::CreateDownload() can
   // call this function with an invalid |db_handle|. For instance, this can
   // happen when the history database is offline. We cannot have multiple
   // DownloadItems with the same invalid db_handle, so we need to assign a
   // unique |db_handle| here.
   if (db_handle == DownloadItem::kUninitializedHandle)
     db_handle = download_history_->GetNextFakeDbHandle();
   download_manager_->OnItemAddedToPersistentStore(download_id, db_handle);
 }