Change dmprof commandline format, and clean up start-up routines.

Change dmprof commandline format, and clean up start-up routines.


BUG=123749
TEST=check dmprof shows the same result.

Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=148138

[Dai Mikurube (NOT FULLTIME), 2012-07-23 04:29:30]

Hi Marc,

Could you take a look at this large change, or forward it to another reviewer? 
Sorry for frequent review requests, and thanks for reviews.

This is a change to
- simplify dmprof commandline, and
- clean up start-up routines
in dmprof based on enabled find_runtime_symbols at
http://codereview.chromium.org/10795043/.

Its cleanup focuses on start-up routines.  I'm planning to clean up other
functions (especially in the Dump class) in another change.

[M-A Ruel, 2012-07-24 14:10:53]

lgtm, sorry for the delay, I had forgot to send the drafts yesterday.

You can look at git_cl.py as an example how to generate the help automatically.

http://codereview.chromium.org/10802049/diff/5004/tools/deep_memory_profiler/...
File tools/deep_memory_profiler/dmprof (right):

http://codereview.chromium.org/10802049/diff/5004/tools/deep_memory_profiler/...
tools/deep_memory_profiler/dmprof:12: from optparse import OptionParser
just import optparse

http://codereview.chromium.org/10802049/diff/5004/tools/deep_memory_profiler/...
tools/deep_memory_profiler/dmprof:34: POLICIES_JSON_PATH =
os.path.join(os.path.dirname(__file__), 'policies.json')
no

http://codereview.chromium.org/10802049/diff/5004/tools/deep_memory_profiler/...
tools/deep_memory_profiler/dmprof:440: 
This new line is gratuitous. Intended?

http://codereview.chromium.org/10802049/diff/5004/tools/deep_memory_profiler/...
tools/deep_memory_profiler/dmprof:833: if len(args) < 2:
what with 10 args?

[Dai Mikurube (NOT FULLTIME), 2012-07-24 14:53:45]

Thank you for reviewing!

Some question on your comments below:

http://codereview.chromium.org/10802049/diff/5004/tools/deep_memory_profiler/...
File tools/deep_memory_profiler/dmprof (right):

http://codereview.chromium.org/10802049/diff/5004/tools/deep_memory_profiler/...
tools/deep_memory_profiler/dmprof:34: POLICIES_JSON_PATH =
os.path.join(os.path.dirname(__file__), 'policies.json')
On 2012/07/24 14:10:53, Marc-Antoine Ruel wrote:
> no

Sorry, what do you mean by this?

http://codereview.chromium.org/10802049/diff/5004/tools/deep_memory_profiler/...
tools/deep_memory_profiler/dmprof:833: if len(args) < 2:
On 2012/07/24 14:10:53, Marc-Antoine Ruel wrote:
> what with 10 args?

It just ignores extra args.  Should it warn or abort?

[M-A Ruel, 2012-07-24 14:57:59]

http://codereview.chromium.org/10802049/diff/5004/tools/deep_memory_profiler/...
File tools/deep_memory_profiler/dmprof (right):

http://codereview.chromium.org/10802049/diff/5004/tools/deep_memory_profiler/...
tools/deep_memory_profiler/dmprof:833: if len(args) < 2:
On 2012/07/24 14:53:45, Dai Mikurube wrote:
> On 2012/07/24 14:10:53, Marc-Antoine Ruel wrote:
> > what with 10 args?
> 
> It just ignores extra args.  Should it warn or abort?

Please abort. Unless it is necessary to ignore during a transition period.
Otherwise this creates problems that are hard to debug.

http://codereview.chromium.org/10802049/diff/9003/tools/deep_memory_profiler/...
File tools/deep_memory_profiler/dmprof (right):

http://codereview.chromium.org/10802049/diff/9003/tools/deep_memory_profiler/...
tools/deep_memory_profiler/dmprof:34: POLICIES_JSON_PATH =
os.path.join(os.path.dirname(__file__), 'policies.json')
os.path.dirname(os.path.abspath(__file__)) for the same reason I mentioned
earlier.

[Dai Mikurube (NOT FULLTIME), 2012-07-24 16:19:24]

Thanks.  Fixed them.

Will be checking the "Commit".

http://codereview.chromium.org/10802049/diff/5004/tools/deep_memory_profiler/...
File tools/deep_memory_profiler/dmprof (right):

http://codereview.chromium.org/10802049/diff/5004/tools/deep_memory_profiler/...
tools/deep_memory_profiler/dmprof:12: from optparse import OptionParser
On 2012/07/24 14:10:53, Marc-Antoine Ruel wrote:
> just import optparse

Done.

http://codereview.chromium.org/10802049/diff/5004/tools/deep_memory_profiler/...
tools/deep_memory_profiler/dmprof:440: 
On 2012/07/24 14:10:53, Marc-Antoine Ruel wrote:
> This new line is gratuitous. Intended?

It was unintended.  Thanks.

http://codereview.chromium.org/10802049/diff/5004/tools/deep_memory_profiler/...
tools/deep_memory_profiler/dmprof:833: if len(args) < 2:
On 2012/07/24 14:57:59, Marc-Antoine Ruel wrote:
> On 2012/07/24 14:53:45, Dai Mikurube wrote:
> > On 2012/07/24 14:10:53, Marc-Antoine Ruel wrote:
> > > what with 10 args?
> > 
> > It just ignores extra args.  Should it warn or abort?
> 
> Please abort. Unless it is necessary to ignore during a transition period.
> Otherwise this creates problems that are hard to debug.

Done.

http://codereview.chromium.org/10802049/diff/9003/tools/deep_memory_profiler/...
File tools/deep_memory_profiler/dmprof (right):

http://codereview.chromium.org/10802049/diff/9003/tools/deep_memory_profiler/...
tools/deep_memory_profiler/dmprof:34: POLICIES_JSON_PATH =
os.path.join(os.path.dirname(__file__), 'policies.json')
On 2012/07/24 14:57:59, Marc-Antoine Ruel wrote:
> os.path.dirname(os.path.abspath(__file__)) for the same reason I mentioned
> earlier.

Ah, I forgot it.  Done.

[commit-bot: I haz the power, 2012-07-24 16:19:42]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/dmikurube@chromium.org/10802049/7004

[commit-bot: I haz the power, 2012-07-24 18:04:25]

Change committed as 148138