Add dependency to HLoadKeyed* instructions to prevent invalid hoisting

test/mjsunit/regress/regress-137768.js

 // Copyright 2012 the V8 project authors. All rights reserved.
 // Redistribution and use in source and binary forms, with or without
 // modification, are permitted provided that the following conditions are
 // met:
 //
 //     * Redistributions of source code must retain the above copyright
 //       notice, this list of conditions and the following disclaimer.
 //     * Redistributions in binary form must reproduce the above
 //       copyright notice, this list of conditions and the following
 //       disclaimer in the documentation and/or other materials provided
 //       with the distribution.
 //     * Neither the name of Google Inc. nor the names of its
 //       contributors may be used to endorse or promote products derived
 //       from this software without specific prior written permission.
 //
 // THIS SOFTWARE IS PROVIDED BY THE COPYRIGHT HOLDERS AND CONTRIBUTORS
 // "AS IS" AND ANY EXPRESS OR IMPLIED WARRANTIES, INCLUDING, BUT NOT
 // LIMITED TO, THE IMPLIED WARRANTIES OF MERCHANTABILITY AND FITNESS FOR
 // A PARTICULAR PURPOSE ARE DISCLAIMED. IN NO EVENT SHALL THE COPYRIGHT
 // OWNER OR CONTRIBUTORS BE LIABLE FOR ANY DIRECT, INDIRECT, INCIDENTAL,
 // SPECIAL, EXEMPLARY, OR CONSEQUENTIAL DAMAGES (INCLUDING, BUT NOT
 // LIMITED TO, PROCUREMENT OF SUBSTITUTE GOODS OR SERVICES; LOSS OF USE,
 // DATA, OR PROFITS; OR BUSINESS INTERRUPTION) HOWEVER CAUSED AND ON ANY
 // THEORY OF LIABILITY, WHETHER IN CONTRACT, STRICT LIABILITY, OR TORT
 // (INCLUDING NEGLIGENCE OR OTHERWISE) ARISING IN ANY WAY OUT OF THE USE
 // OF THIS SOFTWARE, EVEN IF ADVISED OF THE POSSIBILITY OF SUCH DAMAGE.
 
 // Flags: --allow-natives-syntax
 
-// Test optimized closures.
-
-var a = new Array(100);
-
-function f() {
-  var x=0;
-  for (var i=0; i<100; i++) {
-    var g = function goo(y) {
-      function h() {
-        if (goo.arguments[0] == 23) return -42;
-        return 42;
-      }
-      return x + y + h(y);
-    }
-    g(0);
-    %OptimizeFunctionOnNextCall(g);
-    a[i] = g(i);
+function bad_func(o,a) {
+  var s = 0;
+  for (var i = 0; i < 1; ++i) {
+    o.newFileToChangeMap = undefined;
+    var x = a[0];
+    s += Math.floor(a);

[Jakob Kummerow, 2012/07/20 08:45:18]

Did you mean floor(x)? Either way, this test works just fine for me with
bleeding_edge r12151, it doesn't crash and the load is not hoisted out of the
loop (interestingly, with --packed-arrays it's a generic load). Am I missing
something?

   }
+  return s;
 }
 
-f();
-assertEquals(42, a[0]);
-assertEquals(49, a[7]);
-assertEquals(-19, a[23]);
+o = new Object();
+a = [1, 2, 3];
+bad_func(o, a);
 
+// Make sure that we're out of pre-monomorphic state for the member add of
+// 'newFileToChangeMap' which causes a map transition.
+o = new Object();
+a = [1, 2, 3];
+bad_func(o, a);
 
+// Optimize, bofre the fix, the element load and subsequent tagged-to-i were

[Jakob Kummerow, 2012/07/20 08:45:18]

nit: messed up comment ("bofre", incomplete sentence).

+// hoisted above the map check, which can't be hoisted due map-changing store
+// that adds
+o = new Object();
+a = [1, 2, 3];
+%OptimizeFunctionOnNextCall(bad_func);
+bad_func(o, a);
 
-
+// Pass in a array of doubles. Before the fix, the optimized load and
+// tagged-to-i will treat part of a double value as a pointer and de-ref the

[Jakob Kummerow, 2012/07/20 08:45:18]

nit: slightly messed up comment. s/de-ref the/de-ref it/ ?

+// before the map check was executed that should have deopt.
+o = new Object();
+a = [1.5, 2.5, 3.5];
+bad_func(o, a);