maxHeight/Width and miniHeight/Width of chrome.appWindow API failed in ShellWindow.

maxHeight/Width and miniHeight/Width of chrome.appWindow API failed in ShellWindow.


BUG=138001
TEST=manually


Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=149219

[Junmin Zhu, 2012-07-19 03:10:26]

In the "chrome\browser\ui\views\extensions\shell_window_views.cc" line 266 and
284, the frame view need to get maximum/minimum size according to client view's
value, but client view follow View's implementation, which only simplely invokes
GetPreferredSize for GetMinimumSize; and return NULL for GetMinimumSize. It's
not collect.

So client view override the GetMaximumSize() and GetMinimumSize(), which would
help client view to get real maximum/minimum size  from contents view. In the
"shell_window_views.cc" example, it will touch the real content view
(shell_window_views)'s GetMaximumSize()/GetMinimumSize()


Please review the patch.

[Junmin Zhu, 2012-07-30 08:24:14]

Hi Ben,

  Would you help to review this patch? thanks.

[Junmin Zhu, 2012-07-31 00:53:41]

Add mihaip and jeremya to review this patch, who are the issue's owner. Thanks.

[jeremya, 2012-07-31 04:00:28]

sky has changed this area of the code recently with r148241. Perhaps that change
was the cause of this bug?

[jeremya, 2012-07-31 04:01:10]

On 2012/07/31 04:00:28, jeremya wrote:
> sky has changed this area of the code recently with r148241. Perhaps that
change
> was the cause of this bug?

(.. actually, it couldn't have been, because the bug was reported before that
change. Still, though, that patch will conflict with this one.)

[Junmin Zhu, 2012-07-31 06:54:16]

Thanks jeremya,

Scott's commit is for other bug, but it partially fixed this bug with override
the GetMinimumSize function.

We still need to override the GetMaximumSize funtion to fix this bug completely.
So rebase the patch.

Please review it, thanks.

[jeremya, 2012-07-31 06:59:53]

http://codereview.chromium.org/10802028/diff/7001/ui/views/window/client_view.cc
File ui/views/window/client_view.cc (right):

http://codereview.chromium.org/10802028/diff/7001/ui/views/window/client_view...
ui/views/window/client_view.cc:58: contents_view_->GetMaximumSize() :
View::GetMaximumSize();
Why return View::GetMaximumSize() here rather than gfx::Size()?

[Junmin Zhu, 2012-07-31 07:13:48]

> Why return View::GetMaximumSize() here rather than gfx::Size()?

emm, you're right. I first return View::GetMaximumSize and View::GetMinimumSize
when |contents_view_| is NULL, because View::GeMinimumSize defer to
View::GetPreferredSize(), I don't want to change unknown code path. But in
View::GeMaximumSize, it direct return gfx::Size(), which is the same.

update the patch.

[jeremya, 2012-07-31 07:14:37]

lgtm (though you'll also need OWNERS from beng)

[Ben Goodger (Google), 2012-07-31 15:50:54]

lgtm

[commit-bot: I haz the power, 2012-07-31 16:28:45]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/junmin.zhu@intel.com/10802028/12001

[commit-bot: I haz the power, 2012-07-31 17:57:44]

Change committed as 149219