Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(733)

Unified Diff: chrome/browser/prerender/prerender_browsertest.cc

Issue 10802024: Make three simultanious prerenders the default maximum in Canary and Dev only. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: remediation to review, rebase on top of field trial change Created 8 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/prerender/prerender_browsertest.cc
diff --git a/chrome/browser/prerender/prerender_browsertest.cc b/chrome/browser/prerender/prerender_browsertest.cc
index ae5f0f47fa3cd2aa03d8e98d1b98b6552335916d..b9f0a3f429dd6815b09a0d2dfedf17119e624392 100644
--- a/chrome/browser/prerender/prerender_browsertest.cc
+++ b/chrome/browser/prerender/prerender_browsertest.cc
@@ -235,8 +235,8 @@ class TestPrerenderContents : public PrerenderContents {
virtual void AddPendingPrerender(
base::WeakPtr<PrerenderHandle> weak_prerender_handle,
const GURL& url,
- const content::Referrer& referrer,
- const gfx::Size& size) OVERRIDE {
+ const content::Referrer& referrer,
+ const gfx::Size& size) OVERRIDE {
PrerenderContents::AddPendingPrerender(
weak_prerender_handle, url, referrer, size);
if (expected_pending_prerenders_ > 0 &&
@@ -1524,12 +1524,13 @@ IN_PROC_BROWSER_TEST_F(PrerenderBrowserTest, PrerenderInfiniteLoopMultiple) {
const char* const kHtmlFileC =
"files/prerender/prerender_infinite_c_multiple.html";
- // We need to set the final status to expect here before starting any
- // prerenders. We set them on a queue so whichever we see first is expected to
- // be evicted, and the second should stick around until we exit.
+ // This test is conceptually simplest if concurrency is at two, since we
+ // don't have to worry about which of kHtmlFileB or kHtmlFileC gets evicted.
+ GetPrerenderManager()->mutable_config().max_concurrency = 2;
+
std::deque<FinalStatus> expected_final_status_queue;
expected_final_status_queue.push_back(FINAL_STATUS_USED);
- expected_final_status_queue.push_back(FINAL_STATUS_EVICTED);
+ expected_final_status_queue.push_back(FINAL_STATUS_APP_TERMINATING);
expected_final_status_queue.push_back(FINAL_STATUS_APP_TERMINATING);
PrerenderTestURL(kHtmlFileA, expected_final_status_queue, 1);
@@ -1549,8 +1550,7 @@ IN_PROC_BROWSER_TEST_F(PrerenderBrowserTest, PrerenderInfiniteLoopMultiple) {
// active entry.
bool url_b_is_active_prerender = UrlIsInPrerenderManager(kHtmlFileB);
bool url_c_is_active_prerender = UrlIsInPrerenderManager(kHtmlFileC);
- EXPECT_TRUE((url_b_is_active_prerender || url_c_is_active_prerender) &&
- !(url_b_is_active_prerender && url_c_is_active_prerender));
+ EXPECT_TRUE(url_b_is_active_prerender && url_c_is_active_prerender);
EXPECT_FALSE(UrlIsPending(kHtmlFileB));
EXPECT_FALSE(UrlIsPending(kHtmlFileC));
}
« no previous file with comments | « no previous file | chrome/browser/prerender/prerender_config.h » ('j') | chrome/browser/prerender/prerender_config.h » ('J')

Powered by Google App Engine
This is Rietveld 408576698