Issue 108014: Stub out a small portion of the x64 assembler.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 108014: Stub out a small portion of the x64 assembler. (Closed)

Created:
11 years, 7 months ago by Dean McNamee

Modified:
9 years, 7 months ago

Reviewers:
Lasse Reichstein, Kevin Millikin (Chromium)

CC:
v8-dev

Visibility:
Public.

Description

Stub out a small portion of the x64 assembler.

Patch Set 1 #

Total comments: 1

Created: 11 years, 7 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+77 lines, -1 line)			Patch
M	src/x64/assembler-x64.h	View	1 chunk	+67 lines, -0 lines	1 comment	Download
M	src/x64/assembler-x64.cc	View	1 chunk	+9 lines, -0 lines	0 comments	Download
M	src/x64/frames-x64.h	View	1 chunk	+1 line, -1 line	0 comments	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

Kevin Millikin (Chromium)

11 years, 7 months ago (2009-05-05 15:47:59 UTC) #3

http://codereview.chromium.org/108014/diff/1/3
File src/x64/assembler-x64.h (right):

http://codereview.chromium.org/108014/diff/1/3#newcode49
Line 49: // (unfortunately we can't make this private in a struct)
I've never liked this  comment.

Expand Messages | Collapse Messages