Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(429)

Issue 108011: Introduce internal Log class that handles writing log messages, enable logging to memory buffer. (Closed)

Created:
11 years, 7 months ago by Mikhail Naganov
Modified:
9 years, 7 months ago
CC:
v8-dev
Visibility:
Public.

Description

Introduce internal Log class that handles writing log messages, enable logging to memory buffer. This will enable reading profiler log in Chrome. The current implementation of memory buffer is trivial (fixed size buffer, no memory recycling) but enough to start end-to-end DevTools Profiler implementation. Later it will be enhanced. Committed: http://code.google.com/p/v8/source/detail?r=1870

Patch Set 1 #

Total comments: 2
Unified diffs Side-by-side diffs Delta from patch set Stats (+381 lines, -92 lines) Patch
M include/v8.h View 2 chunks +20 lines, -2 lines 2 comments Download
M src/api.cc View 1 chunk +5 lines, -0 lines 0 comments Download
M src/log.h View 6 chunks +7 lines, -19 lines 0 comments Download
M src/log.cc View 40 chunks +238 lines, -71 lines 0 comments Download
M test/cctest/SConscript View 1 chunk +1 line, -0 lines 0 comments Download
A test/cctest/test-log.cc View 1 chunk +102 lines, -0 lines 0 comments Download
M tools/visual_studio/v8_cctest.vcproj View 1 chunk +4 lines, -0 lines 0 comments Download
M tools/visual_studio/v8_cctest_arm.vcproj View 1 chunk +4 lines, -0 lines 0 comments Download

Messages

Total messages: 3 (0 generated)
Mikhail Naganov
11 years, 7 months ago (2009-05-05 13:25:58 UTC) #1
Søren Thygesen Gjesse
LGTM http://codereview.chromium.org/108011/diff/1/2 File include/v8.h (right): http://codereview.chromium.org/108011/diff/1/2#newcode2085 Line 2085: * profiler log data in application. This ...
11 years, 7 months ago (2009-05-05 13:52:35 UTC) #2
Mikhail Naganov
11 years, 7 months ago (2009-05-05 15:56:46 UTC) #3
http://codereview.chromium.org/108011/diff/1/2
File include/v8.h (right):

http://codereview.chromium.org/108011/diff/1/2#newcode2085
Line 2085: * profiler log data in application. This function is thread-safe.
On 2009/05/05 13:52:35, Søren Gjesse wrote:
> Missing the after in.

Done.

Powered by Google App Engine
This is Rietveld 408576698