Issue 108010: Add a x64 stub of frames-inl.h so we have StackHandlerConstants.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 108010: Add a x64 stub of frames-inl.h so we have StackHandlerConstants. (Closed)

Created:
11 years, 7 months ago by Dean McNamee

Modified:
9 years, 7 months ago

Reviewers:
Lasse Reichstein

CC:
v8-dev

Visibility:
Public.

Description

Add a x64 stub of frames-x64.h so we have StackHandlerConstants. This is just a stripped down version of ia32, and will need to change.

Patch Set 1 #

Patch Set 2 : merge tot runk #

Total comments: 1

Patch Set 3 : -1s #

Created: 11 years, 7 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+94 lines, -0 lines)			Patch
	M	src/x64/frames-x64.h	View	1 2	1 chunk	+94 lines, -0 lines	0 comments	Download

Messages

Total messages: 2 (0 generated)

Expand Messages | Collapse Messages

Dean McNamee

Just stubbing stuff out to get the compile further along. This code is all wrong ...

11 years, 7 months ago (2009-05-05 12:12:40 UTC) #1

Lasse Reichstein

11 years, 7 months ago (2009-05-05 12:19:12 UTC) #2

LGTM

http://codereview.chromium.org/108010/diff/1003/1004
File src/x64/frames-x64.h (right):

http://codereview.chromium.org/108010/diff/1003/1004#newcode43
Line 43: static const int kNextOffset  = 0 * kPointerSize;
I know the code is known to be all wrong, but it looks right. Could you change
all the n * kPointerSize to -1 (regexp replace should do the trick :).

Expand Messages | Collapse Messages