Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(3512)

Unified Diff: src/mark-compact.h

Issue 108002: Improved, safer handling of the symbol table. The symbols themselves... (Closed) Base URL: http://v8.googlecode.com/svn/branches/bleeding_edge/
Patch Set: Created 11 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | src/mark-compact.cc » ('j') | src/mark-compact.cc » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: src/mark-compact.h
===================================================================
--- src/mark-compact.h (revision 1848)
+++ src/mark-compact.h (working copy)
@@ -161,18 +161,6 @@
obj->SetMark();
}
- // Used to clear mark bits during marking for objects that are not
- // actually live. Since it updates bookkeeping state, it is not
- // used when clearing mark bits on live objects (eg, during
- // sweeping).
- static inline void ClearMark(HeapObject* obj) {
- obj->ClearMark();
- tracer_->decrement_marked_count();
-#ifdef DEBUG
- UpdateLiveObjectCount(obj, -1);
-#endif
- }
-
// Creates back pointers for all map transitions, stores them in
// the prototype field. The original prototype pointers are restored
// in ClearNonLiveTransitions(). All JSObject maps
@@ -185,8 +173,11 @@
static void MarkDescriptorArray(DescriptorArray* descriptors);
// Mark the heap roots and all objects reachable from them.
- static void ProcessRoots(RootMarkingVisitor* visitor);
+ static void MarkRoots(RootMarkingVisitor* visitor);
+ // Mark the symbol table specially. References to symbols are weak.
iposva 2009/05/05 05:05:19 Please clarify: References to symbols from the sym
+ static void MarkSymbolTable();
+
// Mark objects in object groups that have at least one object in the
// group marked.
static void MarkObjectGroups();
« no previous file with comments | « no previous file | src/mark-compact.cc » ('j') | src/mark-compact.cc » ('J')

Powered by Google App Engine
This is Rietveld 408576698