Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(4700)

Unified Diff: chrome/browser/ui/browser.cc

Issue 10800031: Remove details from BROWSER_CLOSING and BROWSER_CLOSED notifications. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Updated logic / comment for pinned tabs Created 8 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/ui/browser.cc
diff --git a/chrome/browser/ui/browser.cc b/chrome/browser/ui/browser.cc
index 332accd8348287ed66402ae5ede36135b9981fed..a1591dc3b6ab355f41007e9207f79c3a76204c37 100644
--- a/chrome/browser/ui/browser.cc
+++ b/chrome/browser/ui/browser.cc
@@ -591,8 +591,6 @@ void Browser::OnWindowClosing() {
if (!ShouldCloseWindow())
return;
- bool exiting = false;
-
// Application should shutdown on last window close if the user is explicitly
// trying to quit, or if there is nothing keeping the browser alive (such as
// AppController on the Mac, or BackgroundContentsService for background
@@ -600,10 +598,8 @@ void Browser::OnWindowClosing() {
bool should_quit_if_last_browser =
browser_shutdown::IsTryingToQuit() || !browser::WillKeepAlive();
- if (should_quit_if_last_browser && BrowserList::size() == 1) {
+ if (should_quit_if_last_browser && BrowserList::size() == 1)
browser_shutdown::OnShutdownStarting(browser_shutdown::WINDOW_CLOSE);
- exiting = true;
- }
// Don't use GetForProfileIfExisting here, we want to force creation of the
// session service so that user can restore what was open.
@@ -627,7 +623,7 @@ void Browser::OnWindowClosing() {
content::NotificationService::current()->Notify(
chrome::NOTIFICATION_BROWSER_CLOSING,
content::Source<Browser>(this),
- content::Details<bool>(&exiting));
+ content::NotificationService::NoDetails());
chrome::CloseAllTabs(this);
}

Powered by Google App Engine
This is Rietveld 408576698