Log host startup (Linux/Mac)

remoting/host/host_event_logger_posix.cc

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "remoting/host/host_event_logger.h"
 
 #include "base/memory/ref_counted.h"
 #include "base/memory/scoped_ptr.h"
 #include "base/stringprintf.h"
 #include "net/base/ip_endpoint.h"
@@ skipping 38 matching lines @@
 };
 
 } //namespace
 
 HostEventLoggerPosix::HostEventLoggerPosix(ChromotingHost* host,
                                            const std::string& application_name)
     : host_(host),
       application_name_(application_name) {
   openlog(application_name_.c_str(), 0, LOG_USER);
   host_->AddStatusObserver(this);
+  Log("Host started");

[Jamie, 2012/07/18 23:21:34]

Please run this string by the relevant stakeholders to make sure it's specific
enough. Ideally, it should be possible to identify all of our log messages with
a single grep.

[Sergey Ulanov, 2012/07/18 23:28:17]

It's already possible to do that - syslog logs application name next to each
message. application name is specified in the openlog() call above.

[Lambros, 2012/07/18 23:40:56]

I think this string is sufficiently distinctive from the other strings logged
here.  If an objection is raised, we can always change it again :)

[Wez, 2012/07/19 00:41:29]

nit: I think this can simply be "Started" - we already know it's the host
logging it in both syslog and Windows' Event Log.

[Lambros, 2012/07/19 01:36:34]

OK.  If we ever need Host/Client distinction, that should go in the
application_name.

 }
 
 HostEventLoggerPosix::~HostEventLoggerPosix() {
   host_->RemoveStatusObserver(this);
   closelog();

[Sergey Ulanov, 2012/07/18 23:28:17]

also log when the host is stopped?

[Lambros, 2012/07/18 23:40:56]

For Linux Me2Me at least, that code doesn't seem to get called when the host
process is terminated.  Some work would be needed in order to handle SIGTERM
(and maybe other signals) to cause a teardown of these objects.  Since logging
of shutdown wasn't requested, it is probably not worth the effort to do this
work.

 }
 
 void HostEventLoggerPosix::OnClientAuthenticated(const std::string& jid) {
   Log("Client connected: " + jid);
 }
 
 void HostEventLoggerPosix::OnClientDisconnected(const std::string& jid) {
   Log("Client disconnected: " + jid);
 }
 
@@ skipping 21 matching lines @@
 }
 
 // static
 scoped_ptr<HostEventLogger> HostEventLogger::Create(
     ChromotingHost* host, const std::string& application_name) {
   return scoped_ptr<HostEventLogger>(
       new HostEventLoggerPosix(host, application_name));
 }
 
 }  // namespace remoting