Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(246)

Unified Diff: remoting/host/capturer_linux.cc

Issue 10799013: Removing unused and private methods remoting::Capturer interface. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Created 8 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: remoting/host/capturer_linux.cc
diff --git a/remoting/host/capturer_linux.cc b/remoting/host/capturer_linux.cc
index 3a1f22dd15f67277837e42af0e6f8818b5daef8f..14c1f963495a9ba1768334c8ef8d048844b65699 100644
--- a/remoting/host/capturer_linux.cc
+++ b/remoting/host/capturer_linux.cc
@@ -82,12 +82,8 @@ class CapturerLinux : public Capturer {
// Capturer interface.
virtual void Start(const CursorShapeChangedCallback& callback) OVERRIDE;
virtual void Stop() OVERRIDE;
- virtual void ScreenConfigurationChanged() OVERRIDE;
virtual media::VideoFrame::Format pixel_format() const OVERRIDE;
- virtual void ClearInvalidRegion() OVERRIDE;
virtual void InvalidateRegion(const SkRegion& invalid_region) OVERRIDE;
- virtual void InvalidateScreen(const SkISize& size) OVERRIDE;
- virtual void InvalidateFullScreen() OVERRIDE;
virtual void CaptureInvalidRegion(
const CaptureCompletedCallback& callback) OVERRIDE;
virtual const SkISize& size_most_recent() const OVERRIDE;
@@ -115,6 +111,9 @@ class CapturerLinux : public Capturer {
// has been set (using SetCursorShapeChangedCallback).
void CaptureCursor();
+ // Called when the screen configuration is changed.
+ void ScreenConfigurationChanged();
+
// Synchronize the current buffer with |last_buffer_|, by copying pixels from
// the area of |last_invalid_rects|.
// Note this only works on the assumption that kNumBuffers == 2, as
@@ -299,36 +298,14 @@ void CapturerLinux::Start(
void CapturerLinux::Stop() {
}
-void CapturerLinux::ScreenConfigurationChanged() {
- last_buffer_ = NULL;
- for (int i = 0; i < kNumBuffers; ++i) {
- buffers_[i].set_needs_update();
- }
- helper_.ClearInvalidRegion();
- x_server_pixel_buffer_.Init(display_);
-}
-
media::VideoFrame::Format CapturerLinux::pixel_format() const {
return pixel_format_;
}
-void CapturerLinux::ClearInvalidRegion() {
- helper_.ClearInvalidRegion();
-}
-
void CapturerLinux::InvalidateRegion(const SkRegion& invalid_region) {
helper_.InvalidateRegion(invalid_region);
}
-void CapturerLinux::InvalidateScreen(const SkISize& size) {
- helper_.InvalidateScreen(size);
-}
-
-void CapturerLinux::InvalidateFullScreen() {
- helper_.InvalidateFullScreen();
- last_buffer_ = NULL;
-}
-
void CapturerLinux::CaptureInvalidRegion(
const CaptureCompletedCallback& callback) {
// Process XEvents for XDamage and cursor shape tracking.
@@ -484,6 +461,15 @@ CaptureData* CapturerLinux::CaptureFrame() {
return capture_data;
}
+void CapturerLinux::ScreenConfigurationChanged() {
+ last_buffer_ = NULL;
+ for (int i = 0; i < kNumBuffers; ++i) {
+ buffers_[i].set_needs_update();
+ }
+ helper_.ClearInvalidRegion();
+ x_server_pixel_buffer_.Init(display_);
+}
+
void CapturerLinux::SynchronizeFrame() {
// Synchronize the current buffer with the previous one since we do not
// capture the entire desktop. Note that encoder may be reading from the

Powered by Google App Engine
This is Rietveld 408576698