Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(211)

Issue 10797042: Add more using base::Time* to http_cache_transaction.cc. (Closed)

Created:
8 years, 5 months ago by gavinp
Modified:
8 years, 5 months ago
CC:
chromium-reviews, cbentzel+watch_chromium.org, darin-cc_chromium.org, gavinp+disk_chromium.org
Visibility:
Public.

Description

Add more using base::Time* to http_cache_transaction.cc. While working on http://codereview.chromium.org/10808047/ I found we should either use all three basic time types, or none of them. Here's a CL to use all of them. Splitting this out makes the main HttpCache histogram CL more readable by not having these distracting changes. R=rvargas@chromium.org BUG=None Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=147746

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+6 lines, -4 lines) Patch
M net/http/http_cache_transaction.cc View 4 chunks +6 lines, -4 lines 0 comments Download

Messages

Total messages: 4 (0 generated)
gavinp
WDYT?
8 years, 5 months ago (2012-07-20 17:14:07 UTC) #1
rvargas (doing something else)
lgtm
8 years, 5 months ago (2012-07-20 22:38:34 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/gavinp@chromium.org/10797042/1
8 years, 5 months ago (2012-07-20 23:14:46 UTC) #3
commit-bot: I haz the power
8 years, 5 months ago (2012-07-21 00:26:54 UTC) #4
Change committed as 147746

Powered by Google App Engine
This is Rietveld 408576698