base/DEPS - Issue 10797018: Re-enabling checkdeps for most of ppapi + nacl.

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: base/DEPS

Issue 10797018: Re-enabling checkdeps for most of ppapi + nacl. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: tweak base + gpu Created 8 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch | Annotate | Revision Log

OLD	NEW
1 include_rules = [	1 include_rules = [

2 "+jni",	2 "+jni",

3 "+native_client",
brettw 2012/07/25 21:17:38 This change: http://codereview.chromium.org/107950 This change: http://codereview.chromium.org/10795083/ seems to rely on this line being here. Is that change depending on the IRT correct? If so, can we make this line be more specific? bradn 2012/07/25 21:35:57 So there's an outstanding issue of sorts with irt. Show quoted text On 2012/07/25 21:17:38, brettw wrote: > This change: > http://codereview.chromium.org/10795083/ > seems to rely on this line being here. Is that change depending on the IRT > correct? If so, can we make this line be more specific? So there's an outstanding issue of sorts with irt.h not being in the nacl sdk. However, its not sensible to have it in the toolchain, as it depends on what you built into chrome. Within chrome including it directly makes sense, so I think sergeyu's change is ok. I had assumed one of use would land first and we'd merge, and in the current state nothing there is used. Adding what he's planning to have.
4 "+third_party/ashmem",	3 "+third_party/ashmem",

5 "+third_party/apple_apsl",	4 "+third_party/apple_apsl",

6 "+third_party/libevent",	5 "+third_party/libevent",

7 "+third_party/dmg_fp",	6 "+third_party/dmg_fp",

8 "+third_party/GTM",	7 "+third_party/GTM",

9 "+third_party/mach_override",	8 "+third_party/mach_override",

10 "+third_party/modp_b64",	9 "+third_party/modp_b64",

11 "+third_party/tcmalloc",	10 "+third_party/tcmalloc",

12	11

13 # ICU dependendencies must be separate from the rest of base.	12 # ICU dependendencies must be separate from the rest of base.

14 "-i18n",	13 "-i18n",

15 ]	14 ]

OLD	NEW

« no previous file with comments | « DEPS ('k') | chrome/DEPS » ('j') | ppapi/native_client/tests/earth/DEPS » ('J')