ui/base/models/list_model.h - Issue 10797017: base: Make ScopedVector::clear() destroy elements.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: ui/base/models/list_model.h

Issue 10797017: base: Make ScopedVector::clear() destroy elements. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: re-add updated clear method and write a test for weak_clear Created 8 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: ui/base/models/list_model.h

diff --git a/ui/base/models/list_model.h b/ui/base/models/list_model.h

index 95883fc7272817ef3f3134fce982b6101644265f..dbbd689f96c481912469d0b156ecd1cffd2dfb6d 100644

--- a/ui/base/models/list_model.h

+++ b/ui/base/models/list_model.h

@@ -47,7 +47,7 @@ class ListModel {

// Removes all items from the model. This does NOT delete the items.

void RemoveAll() {

size_t count = item_count();

- items_.clear();

+ items_.weak_clear();

NotifyItemsRemoved(0, count);

}