Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(4367)

Unified Diff: chrome/browser/ui/webui/options2/password_manager_handler.cc

Issue 10797017: base: Make ScopedVector::clear() destroy elements. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: update location_bar_view_mac.mm Created 8 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/ui/webui/options2/password_manager_handler.cc
diff --git a/chrome/browser/ui/webui/options2/password_manager_handler.cc b/chrome/browser/ui/webui/options2/password_manager_handler.cc
index 37288469852b78cd8cf96c8e1e2469fe72d602e7..7e6268cdce5e68e25158d901351b5cffb5f93048 100644
--- a/chrome/browser/ui/webui/options2/password_manager_handler.cc
+++ b/chrome/browser/ui/webui/options2/password_manager_handler.cc
@@ -125,8 +125,8 @@ void PasswordManagerHandler::Observe(
void PasswordManagerHandler::UpdatePasswordLists(const ListValue* args) {
// Reset the current lists.
- password_list_.reset();
- password_exception_list_.reset();
+ password_list_.clear();
+ password_exception_list_.clear();
languages_ = Profile::FromWebUI(web_ui())->GetPrefs()->
GetString(prefs::kAcceptLanguages);
@@ -244,7 +244,7 @@ void PasswordManagerHandler::PasswordListPopulater::
const std::vector<webkit::forms::PasswordForm*>& result) {
DCHECK_EQ(pending_login_query_, handle);
pending_login_query_ = 0;
- page_->password_list_.reset();
+ page_->password_list_.clear();
page_->password_list_.insert(page_->password_list_.end(),
result.begin(), result.end());
page_->SetPasswordList();
@@ -273,7 +273,7 @@ void PasswordManagerHandler::PasswordExceptionListPopulater::
const std::vector<webkit::forms::PasswordForm*>& result) {
DCHECK_EQ(pending_login_query_, handle);
pending_login_query_ = 0;
- page_->password_exception_list_.reset();
+ page_->password_exception_list_.clear();
page_->password_exception_list_.insert(page_->password_exception_list_.end(),
result.begin(), result.end());
page_->SetPasswordExceptionList();
« no previous file with comments | « chrome/browser/ui/views/hung_renderer_view.cc ('k') | chrome/browser/webdata/autofill_profile_syncable_service.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698