Added ToJson to JSON schema compiler.

chrome/browser/extensions/api/debugger/debugger_api.cc

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 // Implements the Chrome Extensions Debugger API.
 
 #include "chrome/browser/extensions/api/debugger/debugger_api.h"
 
 #include <map>
 #include <set>
@@ skipping 236 matching lines @@
   DevToolsManager::GetInstance()->DispatchOnInspectorBackend(this, json_args);
 }
 
 void ExtensionDevToolsClientHost::SendDetachedEvent() {
   Profile* profile =
       Profile::FromBrowserContext(web_contents_->GetBrowserContext());
   if (profile != NULL && profile->GetExtensionEventRouter()) {
     Debuggee debuggee;
     debuggee.tab_id = tab_id_;
 
-    scoped_ptr<base::ListValue> args(OnDetach::Create(debuggee));
-    std::string json_args;
-    base::JSONWriter::Write(args.get(), &json_args);
-
+    scoped_ptr<std::string> json_args(OnDetach::ToJson(debuggee));

[not at google - send to devlin, 2012/07/24 23:04:29]

just return string

[mitchellwrosen, 2012/07/25 17:08:20]

Done.

     profile->GetExtensionEventRouter()->DispatchEventToExtension(
-        extension_id_, keys::kOnDetach, json_args, profile, GURL());
+        extension_id_, keys::kOnDetach, *json_args, profile, GURL());
   }
 }
 
 void ExtensionDevToolsClientHost::Observe(
     int type,
     const content::NotificationSource& source,
     const content::NotificationDetails& details) {
   if (type == chrome::NOTIFICATION_EXTENSION_UNLOADED) {
     std::string id =
         content::Details<extensions::UnloadedExtensionInfo>(details)->
@@ skipping 30 matching lines @@
       return;
 
     Debuggee debuggee;
     debuggee.tab_id = tab_id_;
 
     OnEvent::Params params;
     DictionaryValue* params_value;
     if (dictionary->GetDictionary("params", &params_value))
       params.additional_properties.Swap(params_value);
 
-    scoped_ptr<ListValue> args(OnEvent::Create(debuggee, method_name, params));
-    std::string json_args;
-    base::JSONWriter::Write(args.get(), &json_args);
+    scoped_ptr<std::string> json_args(OnEvent::ToJson(debuggee, method_name,
+                                                      params));

[not at google - send to devlin, 2012/07/24 23:04:29]

nit: argument should be on same line or line up vertically. though I think
they'll fit on the same line when scoped_ptr<> goes away.

[mitchellwrosen, 2012/07/25 17:08:20]

Oh, I've seen it both ways. I thought the style guide made it sound like a
judgement call. Anyways, I hope I don't come off sounding impertinent, I'll
change it! =)

 
     profile->GetExtensionEventRouter()->DispatchEventToExtension(
-        extension_id_, keys::kOnEvent, json_args, profile, GURL());
+        extension_id_, keys::kOnEvent, *json_args, profile, GURL());
   } else {
     SendCommandDebuggerFunction* function = pending_requests_[id];
     if (!function)
       return;
 
     function->SendResponseBody(dictionary);
     pending_requests_.erase(id);
   }
 }
 
@@ skipping 158 matching lines @@
   }
 
   DictionaryValue* result_body;
   SendCommand::Results::Result result;
   if (response->GetDictionary("result", &result_body))
     result.additional_properties.Swap(result_body);
 
   results_ = SendCommand::Results::Create(result);
   SendResponse(true);
 }