ui/aura/window_delegate.h - Issue 10796106: aura: Rename OnWindowVisisbilityChanged() to OnWindowTargetVisibilityChanged().

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: ui/aura/window_delegate.h

Issue 10796106: aura: Rename OnWindowVisisbilityChanged() to OnWindowTargetVisibilityChanged(). (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: Created 8 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: ui/aura/window_delegate.h

diff --git a/ui/aura/window_delegate.h b/ui/aura/window_delegate.h

index 778311ccba4baf291e349bd5f63b38a464629a9a..0bb98472fb371d0df2345696e79313c7ec0a1410 100644

--- a/ui/aura/window_delegate.h

+++ b/ui/aura/window_delegate.h

@@ -86,9 +86,7 @@ class AURA_EXPORT WindowDelegate {

// Called when the visibility of a Window changes. See description in

sky 2012/07/24 16:29:40 visibility -> TargetVisiblity()

sky 2012/07/24 16:29:40 Replace the second sentence with |visible| corresp

// WindowObserver::OnWindowDestroyed() for details.

- // TODO: this should be renamed to OnWindowTargetVisibilityChanged() to

- // match when it's sent.

- virtual void OnWindowVisibilityChanged(bool visible) = 0;

+ virtual void OnWindowTargetVisibilityChanged(bool visible) = 0;

// Called from Window::HitTest to check if the window has a custom hit test

// mask. It works similar to the views counterparts. That is, if the function

« no previous file with comments | « ui/aura/window.cc ('k') | ui/aura/window_unittest.cc » ('j') | no next file with comments »