Issue 10796097: [Chromoting] Fix jscompiler warnings in client_plugin_async.js

Issue 10796097: [Chromoting] Fix jscompiler warnings in client_plugin_async.js (Closed)

Created:
8 years, 5 months ago by garykac

Modified:
8 years, 5 months ago

Reviewers:
Sergey Ulanov

CC:
chromium-reviews, jamiewalch+watch_chromium.org, dcaiafa+watch_chromium.org, simonmorris+watch_chromium.org, hclam+watch_chromium.org, wez+watch_chromium.org, amit, sanjeevr, garykac+watch_chromium.org, lambroslambrou+watch_chromium.org, alexeypa+watch_chromium.org, sergeyu+watch_chromium.org

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Visibility:
Public.

More Reviews

Description

[Chromoting] Fix jscompiler warnings in client_plugin_async.js BUG=None TEST=jscompiler reports no warnings. Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=148004

Patch Set 1 #

Total comments: 2

Created: 8 years, 5 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+2 lines, -1 line)			Patch
	M	remoting/webapp/client_plugin_async.js	View		1 chunk	+2 lines, -1 line	2 comments	Download

Messages

Total messages: 5 (0 generated)

Expand Messages | Collapse Messages

Sergey Ulanov

lgtm http://codereview.chromium.org/10796097/diff/1/remoting/webapp/client_plugin_async.js File remoting/webapp/client_plugin_async.js (right): http://codereview.chromium.org/10796097/diff/1/remoting/webapp/client_plugin_async.js#newcode207 remoting/webapp/client_plugin_async.js:207: this.onConnectionReadyHandler(ready); Might be better to write like this: ...

8 years, 5 months ago (2012-07-23 21:39:33 UTC) #2

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/garykac@chromium.org/10796097/1

8 years, 5 months ago (2012-07-23 22:34:24 UTC) #3

garykac

http://codereview.chromium.org/10796097/diff/1/remoting/webapp/client_plugin_async.js File remoting/webapp/client_plugin_async.js (right): http://codereview.chromium.org/10796097/diff/1/remoting/webapp/client_plugin_async.js#newcode207 remoting/webapp/client_plugin_async.js:207: this.onConnectionReadyHandler(ready); On 2012/07/23 21:39:34, sergeyu wrote: > Might be ...

8 years, 5 months ago (2012-07-23 22:45:25 UTC) #4

Change committed as 148004

Expand Messages | Collapse Messages