Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(500)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 10796096: Add tracing of all memory allocated in all contexts (Closed)

Created:
8 years, 5 months ago by ccameron
Modified:
8 years, 4 months ago
Reviewers:
greggman
CC:
chromium-reviews, joi+watch-content_chromium.org, darin-cc_chromium.org, jam, apatrick_chromium
Visibility:
Public.

Description

Add global tracking of GPU memory allocations. Have each ContextGroup push memory tracking information to the GpuMemoryManager. With this we can determine if we transiently oversubscribe. BUG=135525 TEST= Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=148880

Patch Set 1 #

Patch Set 2 : Not for review -- global memory tracking work #

Patch Set 3 : Add global memory usage tracking #

Total comments: 6

Patch Set 4 : Incorporate review feedback #

Patch Set 5 : Fix trybot failures #

Patch Set 6 : Rebase and resolve #

Patch Set 7 : More trybot feedback. #

Patch Set 8 : Fix constructors in unittests #

Patch Set 9 : More trybot constructor fixes #

Unified diffs Side-by-side diffs Delta from patch set Stats (+237 lines, -67 lines) Patch
M content/common/gpu/gpu_command_buffer_stub.cc View 1 2 3 4 5 6 3 chunks +23 lines, -1 line 0 comments Download
M content/common/gpu/gpu_memory_manager.h View 1 2 2 chunks +7 lines, -6 lines 0 comments Download
M content/common/gpu/gpu_memory_manager.cc View 1 2 4 chunks +26 lines, -4 lines 0 comments Download
M gpu/command_buffer/service/buffer_manager.h View 1 2 4 chunks +6 lines, -2 lines 0 comments Download
M gpu/command_buffer/service/buffer_manager.cc View 1 2 2 chunks +8 lines, -8 lines 0 comments Download
M gpu/command_buffer/service/buffer_manager_unittest.cc View 1 2 3 4 5 6 7 1 chunk +1 line, -1 line 0 comments Download
M gpu/command_buffer/service/context_group.h View 1 2 3 4 5 4 chunks +7 lines, -0 lines 0 comments Download
M gpu/command_buffer/service/context_group.cc View 1 2 3 4 5 5 chunks +13 lines, -4 lines 0 comments Download
M gpu/command_buffer/service/context_group_unittest.cc View 1 2 1 chunk +1 line, -1 line 0 comments Download
M gpu/command_buffer/service/framebuffer_manager_unittest.cc View 1 2 3 4 5 6 7 2 chunks +6 lines, -4 lines 0 comments Download
M gpu/command_buffer/service/gles2_cmd_decoder_unittest_base.cc View 1 2 3 4 5 1 chunk +3 lines, -1 line 0 comments Download
A gpu/command_buffer/service/memory_tracking.h View 1 2 3 4 1 chunk +77 lines, -0 lines 0 comments Download
M gpu/command_buffer/service/renderbuffer_manager.h View 1 2 3 chunks +8 lines, -1 line 0 comments Download
M gpu/command_buffer/service/renderbuffer_manager.cc View 1 2 2 chunks +10 lines, -4 lines 0 comments Download
M gpu/command_buffer/service/renderbuffer_manager_unittest.cc View 1 2 3 4 5 6 7 1 chunk +1 line, -1 line 0 comments Download
M gpu/command_buffer/service/texture_manager.h View 1 2 4 chunks +6 lines, -2 lines 0 comments Download
M gpu/command_buffer/service/texture_manager.cc View 1 2 3 4 chunks +8 lines, -8 lines 0 comments Download
M gpu/command_buffer/service/texture_manager_unittest.cc View 1 2 3 4 5 6 7 13 chunks +15 lines, -13 lines 0 comments Download
M gpu/command_buffer/service/vertex_attrib_manager_unittest.cc View 1 2 3 4 5 6 7 8 3 chunks +3 lines, -3 lines 0 comments Download
M gpu/command_buffer/tests/gl_manager.cc View 1 2 3 4 5 1 chunk +1 line, -0 lines 0 comments Download
M gpu/demos/framework/window.cc View 1 2 3 4 5 1 chunk +3 lines, -1 line 0 comments Download
M gpu/gles2_conform_support/egl/display.cc View 1 2 3 4 5 1 chunk +3 lines, -1 line 0 comments Download
M webkit/gpu/webgraphicscontext3d_in_process_command_buffer_impl.cc View 1 2 3 4 5 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 7 (0 generated)
ccameron
8 years, 5 months ago (2012-07-27 03:19:22 UTC) #1
greggman
a few comments but otherwise LGTM http://codereview.chromium.org/10796096/diff/2002/gpu/command_buffer/service/memory_tracking.h File gpu/command_buffer/service/memory_tracking.h (right): http://codereview.chromium.org/10796096/diff/2002/gpu/command_buffer/service/memory_tracking.h#newcode58 gpu/command_buffer/service/memory_tracking.h:58: MemoryTracker* memory_tracker_; style: ...
8 years, 4 months ago (2012-07-27 19:39:43 UTC) #2
ccameron
http://codereview.chromium.org/10796096/diff/2002/gpu/command_buffer/service/memory_tracking.h File gpu/command_buffer/service/memory_tracking.h (right): http://codereview.chromium.org/10796096/diff/2002/gpu/command_buffer/service/memory_tracking.h#newcode58 gpu/command_buffer/service/memory_tracking.h:58: MemoryTracker* memory_tracker_; On 2012/07/27 19:39:43, greggman wrote: > style: ...
8 years, 4 months ago (2012-07-27 20:14:34 UTC) #3
ccameron
8 years, 4 months ago (2012-07-27 21:39:37 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/ccameron@chromium.org/10796096/2005
8 years, 4 months ago (2012-07-28 00:18:17 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/ccameron@chromium.org/10796096/2007
8 years, 4 months ago (2012-07-28 01:31:47 UTC) #6
commit-bot: I haz the power
8 years, 4 months ago (2012-07-28 04:00:23 UTC) #7 
Change committed as 148880

Powered by Google App Engine
This is Rietveld 408576698