Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(94)

Unified Diff: net/socket/socket_test_util.cc

Issue 10796085: Give MockRead and MockWrite distinct types. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Fix jingle tests. Created 8 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: net/socket/socket_test_util.cc
diff --git a/net/socket/socket_test_util.cc b/net/socket/socket_test_util.cc
index 34af3709c8d5b6b509965b066e2f0a76fb22c95a..9a8a6387008097c7291e7600b2d63f6319dd1f25 100644
--- a/net/socket/socket_test_util.cc
+++ b/net/socket/socket_test_util.cc
@@ -109,7 +109,8 @@ void DumpData(const char* data, int data_len) {
}
}
-void DumpMockRead(const MockRead& r) {
+template <MockReadWriteType type>
+void DumpMockReadWrite(const MockReadWrite<type>& r) {
if (logging::LOG_INFO < logging::GetMinLogLevel())
return;
DVLOG(1) << "Async: " << (r.mode == ASYNC)
@@ -390,14 +391,14 @@ MockRead OrderedSocketData::GetNextRead() {
sequence_number_++) {
NET_TRACE(INFO, " *** ") << "Stage " << sequence_number_ - 1
<< ": Read " << read_index();
- DumpMockRead(next_read);
+ DumpMockReadWrite(next_read);
blocked_ = (next_read.result == ERR_IO_PENDING);
return StaticSocketDataProvider::GetNextRead();
}
NET_TRACE(INFO, " *** ") << "Stage " << sequence_number_ - 1
<< ": I/O Pending";
MockRead result = MockRead(ASYNC, ERR_IO_PENDING);
- DumpMockRead(result);
+ DumpMockReadWrite(result);
blocked_ = true;
return result;
}
@@ -405,7 +406,7 @@ MockRead OrderedSocketData::GetNextRead() {
MockWriteResult OrderedSocketData::OnWrite(const std::string& data) {
NET_TRACE(INFO, " *** ") << "Stage " << sequence_number_
<< ": Write " << write_index();
- DumpMockRead(PeekWrite());
+ DumpMockReadWrite(PeekWrite());
++sequence_number_;
if (blocked_) {
// TODO(willchan): This 100ms delay seems to work around some weirdness. We
@@ -518,14 +519,14 @@ MockRead DeterministicSocketData::GetNextRead() {
result = MockRead(SYNCHRONOUS, ERR_UNEXPECTED);
}
if (print_debug_)
- DumpMockRead(result);
+ DumpMockReadWrite(result);
return result;
}
NET_TRACE(INFO, " *** ") << "Stage " << sequence_number_
<< ": Read " << read_index();
if (print_debug_)
- DumpMockRead(current_read_);
+ DumpMockReadWrite(current_read_);
// Increment the sequence number if IO is complete
if (current_read_.mode == SYNCHRONOUS)
@@ -562,7 +563,7 @@ MockWriteResult DeterministicSocketData::OnWrite(const std::string& data) {
}
if (print_debug_)
- DumpMockRead(next_write);
+ DumpMockReadWrite(next_write);
// Move to the next step if I/O is synchronous, since the operation will
// complete when this method returns.

Powered by Google App Engine
This is Rietveld 408576698