Issue 10796064: PPAPI/NaCl: Make nacl_ipc_adapter handle ImageData creation

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 10796064: PPAPI/NaCl: Make nacl_ipc_adapter handle ImageData creation (Closed)

Created:
8 years, 5 months ago by dmichael (off chromium)

Modified:
8 years, 4 months ago

Reviewers:

CC:
chromium-reviews, native-client-reviews_googlegroups.com

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Visibility:
Public.

More Reviews

Description

PPAPI/NaCl: Make nacl_ipc_adapter handle ImageData creation Closing uncommitted. I went with a general approach instead, in this CL: http://codereview.chromium.org/10828023/ BUG=116317 TEST=

Patch Set 1 #

Patch Set 2 : starting to try some templaty stuff to break apart messages #

Patch Set 3 : Sketch of idea for extracting handles generally #

Created: 8 years, 5 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+733 lines, -157 lines)			Patch
M	chrome/nacl/nacl_ipc_adapter.h	View		3 chunks	+7 lines, -0 lines	0 comments	Download
M	chrome/nacl/nacl_ipc_adapter.cc	View	1 2	4 chunks	+171 lines, -42 lines	0 comments	Download
M	chrome/renderer/pepper/ppb_pdf_impl.cc	View	1	1 chunk	+3 lines, -1 line	0 comments	Download
M	ppapi/proxy/ppapi_messages.h	View	1 2	3 chunks	+20 lines, -4 lines	0 comments	Download
M	ppapi/proxy/ppb_audio_proxy.h	View	1 2	2 chunks	+7 lines, -5 lines	0 comments	Download
M	ppapi/proxy/ppb_audio_proxy.cc	View	1 2	2 chunks	+11 lines, -9 lines	0 comments	Download
M	ppapi/proxy/ppb_buffer_proxy.h	View	1	1 chunk	+0 lines, -1 line	0 comments	Download
M	ppapi/proxy/ppb_buffer_proxy.cc	View	1	2 chunks	+1 line, -2 lines	0 comments	Download
M	ppapi/proxy/ppb_image_data_proxy.h	View	1	5 chunks	+25 lines, -2 lines	0 comments	Download
M	ppapi/proxy/ppb_image_data_proxy.cc	View	1	10 chunks	+101 lines, -9 lines	0 comments	Download
M	ppapi/proxy/resource_creation_proxy.h	View	1	1 chunk	+4 lines, -0 lines	0 comments	Download
M	ppapi/proxy/resource_creation_proxy.cc	View	1	1 chunk	+11 lines, -0 lines	0 comments	Download
M	ppapi/proxy/serialized_structs.h	View	1 2	1 chunk	+16 lines, -0 lines	0 comments	Download
M	ppapi/thunk/ppb_image_data_api.h	View	1	2 chunks	+19 lines, -2 lines	0 comments	Download
M	ppapi/thunk/resource_creation_api.h	View	1	1 chunk	+4 lines, -0 lines	0 comments	Download
M	ui/gfx/blit.cc	View	1	2 chunks	+17 lines, -22 lines	0 comments	Download
M	webkit/plugins/ppapi/ppapi_plugin_instance.cc	View	1	2 chunks	+5 lines, -1 line	0 comments	Download
M	webkit/plugins/ppapi/ppb_graphics_2d_impl.cc	View	1	4 chunks	+5 lines, -4 lines	0 comments	Download
M	webkit/plugins/ppapi/ppb_image_data_impl.h	View	1	5 chunks	+96 lines, -18 lines	0 comments	Download
M	webkit/plugins/ppapi/ppb_image_data_impl.cc	View	1	4 chunks	+197 lines, -34 lines	0 comments	Download
M	webkit/plugins/ppapi/resource_creation_impl.h	View	1	1 chunk	+4 lines, -0 lines	0 comments	Download
M	webkit/plugins/ppapi/resource_creation_impl.cc	View	1	1 chunk	+9 lines, -1 line	0 comments	Download