Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1155)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 10796033: Move files related to registry-controlled domains into a new net/base/registry_controlled_domains/ … (Closed)

Created:
8 years, 5 months ago by Pam (message me for reviews)
Modified:
8 years, 5 months ago
Reviewers:
agl, Peter Kasting, sky
CC:
chromium-reviews, cbentzel+watch_chromium.org, mihaip-chromium-reviews_chromium.org, creis+watch_chromium.org, erikwright (departed), rkn, jam, joi+watch-content_chromium.org, Aaron Boodman, wtc, darin-cc_chromium.org, ajwong+watch_chromium.org, pam+watch_chromium.org, James Su, brettw-cc_chromium.org
Visibility:
Public.

Description

Move files related to registry-controlled domains into a new net/base/registry_controlled_domains/ subdirectory. This includes net/base/registry_controlled_domain.* and net/base/effective_tld_names* BUG=138047 TEST=covered by existing tests Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=147641

Patch Set 1 #

Patch Set 2 : Update checkout #

Patch Set 3 : More updated includes #

Patch Set 4 : Even more updated includes #

Patch Set 5 : License header fixes #

Patch Set 6 : Update checkout #

Unified diffs Side-by-side diffs Delta from patch set Stats (+64 lines, -13637 lines) Patch
M chrome/browser/alternate_nav_url_fetcher.cc View 1 2 3 4 5 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/autocomplete/autocomplete_input.cc View 1 2 3 4 5 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/autocomplete/history_url_provider.cc View 1 2 3 4 5 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/browsing_data/browsing_data_cookie_helper.cc View 1 2 3 4 5 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/content_settings/local_shared_objects_container.cc View 1 2 3 4 5 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/cookies_tree_model.cc View 1 2 3 4 5 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/extensions/extension_service.cc View 1 2 3 4 5 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/google/google_util.cc View 1 2 3 4 5 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/history/history_backend.cc View 1 2 3 4 5 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/intranet_redirect_detector.cc View 1 2 3 4 5 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/net/sqlite_persistent_cookie_store.cc View 1 2 3 4 5 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/net/url_fixer_upper.cc View 1 2 3 4 5 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/protector/protector_service.cc View 1 2 3 4 5 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/safe_browsing/safe_browsing_service.cc View 1 2 3 4 5 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/ui/browser.cc View 1 2 3 4 5 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/ui/constrained_window_tab_helper.cc View 1 2 3 4 5 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/ui/toolbar/back_forward_menu_model.cc View 1 2 3 4 5 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/ui/website_settings/website_settings.cc View 1 2 3 4 5 1 chunk +1 line, -1 line 0 comments Download
M chrome/common/extensions/extension.cc View 1 2 3 4 5 1 chunk +1 line, -1 line 0 comments Download
M chrome/common/extensions/permissions/permission_set.cc View 1 2 3 4 5 1 chunk +1 line, -1 line 0 comments Download
M chrome/renderer/safe_browsing/phishing_dom_feature_extractor.cc View 1 2 3 4 5 1 chunk +1 line, -1 line 0 comments Download
M chrome/renderer/safe_browsing/phishing_url_feature_extractor.cc View 1 2 3 4 5 2 chunks +2 lines, -2 lines 0 comments Download
M chrome_frame/ready_mode/ready_mode.cc View 1 2 3 4 5 2 chunks +2 lines, -2 lines 0 comments Download
M content/browser/renderer_host/resource_dispatcher_host_impl.cc View 1 2 3 4 5 1 chunk +1 line, -1 line 0 comments Download
M content/browser/site_instance_impl.cc View 1 2 3 4 5 1 chunk +1 line, -1 line 0 comments Download
M content/browser/worker_host/worker_process_host.cc View 1 2 3 4 5 1 chunk +1 line, -1 line 0 comments Download
M content/browser/worker_host/worker_service_impl.cc View 1 2 3 4 5 1 chunk +1 line, -1 line 0 comments Download
D net/base/effective_tld_names.dat View 1 2 3 4 5 1 chunk +0 lines, -6841 lines 0 comments Download
D net/base/effective_tld_names.gperf View 1 2 3 4 5 1 chunk +0 lines, -5664 lines 0 comments Download
D net/base/effective_tld_names_unittest1.cc View 1 2 3 4 5 1 chunk +0 lines, -183 lines 0 comments Download
D net/base/effective_tld_names_unittest1.gperf View 1 2 3 4 5 1 chunk +0 lines, -23 lines 0 comments Download
D net/base/effective_tld_names_unittest2.cc View 1 2 3 4 5 1 chunk +0 lines, -150 lines 0 comments Download
D net/base/effective_tld_names_unittest2.gperf View 1 2 3 4 5 1 chunk +0 lines, -17 lines 0 comments Download
D net/base/registry_controlled_domain.h View 1 2 3 4 5 1 chunk +0 lines, -217 lines 0 comments Download
D net/base/registry_controlled_domain.cc View 1 2 3 4 5 1 chunk +0 lines, -254 lines 0 comments Download
D net/base/registry_controlled_domain_unittest.cc View 1 2 3 4 5 1 chunk +0 lines, -230 lines 0 comments Download
A net/base/registry_controlled_domains/OWNERS View 1 2 3 4 5 1 chunk +2 lines, -0 lines 0 comments Download
A + net/base/registry_controlled_domains/effective_tld_names.cc View 0 chunks +-1 lines, --1 lines 0 comments Download
A + net/base/registry_controlled_domains/effective_tld_names.dat View 1 2 3 4 5 0 chunks +-1 lines, --1 lines 0 comments Download
A + net/base/registry_controlled_domains/effective_tld_names.gperf View 1 2 3 4 5 0 chunks +-1 lines, --1 lines 0 comments Download
A + net/base/registry_controlled_domains/effective_tld_names_unittest1.cc View 1 2 3 4 5 1 chunk +4 lines, -4 lines 0 comments Download
A + net/base/registry_controlled_domains/effective_tld_names_unittest1.gperf View 1 2 3 4 5 1 chunk +3 lines, -3 lines 0 comments Download
A + net/base/registry_controlled_domains/effective_tld_names_unittest2.cc View 1 2 3 4 5 1 chunk +3 lines, -3 lines 0 comments Download
A + net/base/registry_controlled_domains/effective_tld_names_unittest2.gperf View 1 2 3 4 5 1 chunk +3 lines, -3 lines 0 comments Download
A + net/base/registry_controlled_domains/registry_controlled_domain.h View 1 2 3 4 5 3 chunks +4 lines, -4 lines 0 comments Download
A + net/base/registry_controlled_domains/registry_controlled_domain.cc View 1 2 3 4 5 1 chunk +1 line, -1 line 0 comments Download
A + net/base/registry_controlled_domains/registry_controlled_domain_unittest.cc View 1 2 3 4 5 1 chunk +1 line, -1 line 0 comments Download
M net/base/sdch_manager.cc View 1 2 3 4 5 2 chunks +2 lines, -2 lines 0 comments Download
M net/base/server_bound_cert_service.cc View 1 2 3 4 5 1 chunk +1 line, -1 line 0 comments Download
M net/base/static_cookie_policy.cc View 1 2 3 4 5 2 chunks +2 lines, -2 lines 0 comments Download
M net/cookies/cookie_monster.cc View 1 2 3 4 5 1 chunk +1 line, -1 line 0 comments Download
M net/cookies/cookie_util.cc View 1 2 3 4 5 1 chunk +1 line, -1 line 0 comments Download
M net/net.gyp View 1 2 3 4 5 2 chunks +3 lines, -3 lines 0 comments Download
M net/tools/tld_cleanup/README View 1 2 3 4 5 2 chunks +2 lines, -2 lines 0 comments Download
M net/tools/tld_cleanup/tld_cleanup.cc View 1 2 3 4 5 1 chunk +4 lines, -0 lines 0 comments Download
M ui/base/text/text_elider.cc View 1 2 3 4 5 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 4 (0 generated)
Pam (message me for reviews)
pkasting: Please review net/base/registry_controlled_domains/ (the move itself) and tld_cleanup.cc. sky, agl: Please review as OWNERS ...
8 years, 5 months ago (2012-07-19 19:04:40 UTC) #1
Peter Kasting
LGTM
8 years, 5 months ago (2012-07-19 19:28:44 UTC) #2
agl
lgtm
8 years, 5 months ago (2012-07-19 19:30:45 UTC) #3
sky
8 years, 5 months ago (2012-07-19 20:26:20 UTC) #4 
LGTM - feel free to TBR this in the future.

Powered by Google App Engine
This is Rietveld 408576698