Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2571)

Unified Diff: scripts/master/try_job_rietveld.py

Issue 10796027: Make the users empty when there is no passowrd file. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/tools/build/
Patch Set: Created 8 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: scripts/master/try_job_rietveld.py
===================================================================
--- scripts/master/try_job_rietveld.py (revision 147367)
+++ scripts/master/try_job_rietveld.py (working copy)
@@ -65,13 +65,16 @@
A frozenset of string containing the email addresses of users allowed to
send jobs from Rietveld.
"""
- pwd = open(self._PWD_FILE).readline().strip()
+ try:
M-A Ruel 2012/07/19 11:57:28 I'd prefer a if os.path.isfile() and be sure to
Peter Mayo 2012/07/19 19:12:52 SGTM ... once running I'm not sure if the preferre
+ pwd = open(self._PWD_FILE).readline().strip()
+ except IOError:
+ return frozenset([])
+
now_string = str(int(time.time()))
params = {
'md5': hashlib.md5(pwd + now_string).hexdigest(),
'time': now_string
}
-
return client.getPage('https://chromium-access.appspot.com/auto/users',
agent='buildbot',
method='POST',
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698