Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(185)

Issue 10795100: Accept CSS url()s without quotes. (Closed)

Created:
8 years, 5 months ago by newt (away)
Modified:
8 years, 5 months ago
Reviewers:
Jói
CC:
grit-developer_googlegroups.com
Visibility:
Public.

Description

Accept CSS url()s without quotes. This inlines images in the CSS url() function, even if the image name is not surrounded by quotes. e.g. url(test.png) is now treated like url('test.png'). The Google CSS style guide recommends using url() without quotes, and this allows us to follow that style. BUG=https://code.google.com/p/chromium/issues/detail?id=138849 Committed: https://code.google.com/p/grit-i18n/source/detail?r=62

Patch Set 1 #

Patch Set 2 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+63 lines, -10 lines) Patch
M grit/format/html_inline.py View 1 2 chunks +12 lines, -7 lines 0 comments Download
M grit/gather/chrome_html.py View 1 1 chunk +3 lines, -3 lines 0 comments Download
M grit/gather/chrome_html_unittest.py View 1 1 chunk +48 lines, -0 lines 0 comments Download

Messages

Total messages: 3 (0 generated)
newt (away)
I think this is a desirable change. Let me know what you think. Thanks.
8 years, 5 months ago (2012-07-24 23:41:54 UTC) #1
newt (away)
Here's the complete change, test and all. (I probably should have mentioned that the previous ...
8 years, 5 months ago (2012-07-25 21:03:24 UTC) #2
Jói
8 years, 5 months ago (2012-07-25 21:45:22 UTC) #3
LGTM, great, thanks!

Powered by Google App Engine
This is Rietveld 408576698