Enable some parts of base that were previously disabled in base_untrusted

base/rand_util_nacl.cc

+// Copyright (c) 2012 The Chromium Authors. All rights reserved.
+// Use of this source code is governed by a BSD-style license that can be
+// found in the LICENSE file.
+
+#include "base/rand_util.h"
+
+#include "base/lazy_instance.h"
+#include "base/logging.h"
+#include "native_client/src/untrusted/irt/irt.h"
+
+namespace {
+
+class NaclRandom {
+ public:
+  NaclRandom() {
+    int success = nacl_interface_query(NACL_IRT_RANDOM_v0_1,
+                                       &random_, sizeof(random_));
+    if (!success)
+      LOG(FATAL) << "Failed to initialize RNG.";

[willchan no longer on Chromium, 2012/07/25 17:52:55]

Can you split this out into DLOG(ERROR) with the message and then a
CHECK(false)? I don't think we need this string linked into an official build.
Binary bloat by a thousand cuts. Or if you don't need the message, just kill it.

[Sergey Ulanov, 2012/07/25 19:43:23]

Replaced with CHECK()

+  }
+
+  ~NaclRandom() {
+  }
+
+  void GetRandomBytes(char* buffer, uint32_t num_bytes) {
+    while (num_bytes > 0) {
+      size_t nread;
+      int error = random_.get_random_bytes(buffer, num_bytes, &nread);
+      CHECK(error != 0) << "Failed to get random bytes.";

[willchan no longer on Chromium, 2012/07/25 17:52:55]

Ditto here on the CHECKs with messages. Ditch the messages unless you really
need them.

[Sergey Ulanov, 2012/07/25 19:43:23]

Done.

+      CHECK_LE(nread, num_bytes);
+      buffer += nread;
+      num_bytes -= nread;
+    }
+  }
+
+ private:
+  nacl_irt_random random_;
+};
+
+base::LazyInstance<NaclRandom> g_nacl_random = LAZY_INSTANCE_INITIALIZER;

[willchan no longer on Chromium, 2012/07/25 17:52:55]

Should this be leaky? I don't know anything about NACL, but it seems like it'd
be bad if another thread were running that was calling RandUint64(), while the
main thread's AtExitManager was deleting NaclRandom.

[Sergey Ulanov, 2012/07/25 19:43:23]

Done.

+
+}  // namespace
+
+namespace base {
+
+uint64 RandUint64() {
+  uint64 result;

[willchan no longer on Chromium, 2012/07/25 17:52:55]

I think you may need basictypes.h for this type.

[Sergey Ulanov, 2012/07/25 19:43:23]

Done.

+  g_nacl_random.Pointer()->GetRandomBytes(
+      reinterpret_cast<char*>(&result), sizeof(result));
+  return result;
+}
+
+}  // namespace base