Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(242)

Unified Diff: src/builtins.cc

Issue 10795074: Add a new API V8::SetJitCodeEventHandler to push code name and location to users such as profilers. (Closed) Base URL: https://v8.googlecode.com/svn/branches/bleeding_edge
Patch Set: Ready for review Created 8 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « src/assembler.h ('k') | src/code-events.h » ('j') | src/code-events.h » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: src/builtins.cc
diff --git a/src/builtins.cc b/src/builtins.cc
index 64ec3d9fcc485f9d8fe9c7856072c4f5c4cea84b..4de27854a047450e614840fd8ef8d3ea564b9c7e 100644
--- a/src/builtins.cc
+++ b/src/builtins.cc
@@ -31,7 +31,7 @@
#include "arguments.h"
#include "bootstrapper.h"
#include "builtins.h"
-#include "gdb-jit.h"
+#include "code-events.h"
#include "ic-inl.h"
#include "heap-profiler.h"
#include "mark-compact.h"
@@ -1643,9 +1643,8 @@ void Builtins::SetUp(bool create_heap_objects) {
CodeCreateEvent(Logger::BUILTIN_TAG,
Code::cast(code),
functions[i].s_name));
- GDBJIT(AddCode(GDBJITInterface::BUILTIN,
- functions[i].s_name,
- Code::cast(code)));
+ JIT_CODE_EVENT(AddCode(functions[i].s_name,
danno 2012/07/25 13:50:42 Why do you remove the code event type? It seems th
Sigurður Ásgeirsson 2012/07/25 14:38:35 I discussed this with @vegorov at some length, and
+ Code::cast(code)));
builtins_[i] = code;
#ifdef ENABLE_DISASSEMBLER
if (FLAG_print_builtin_code) {
« no previous file with comments | « src/assembler.h ('k') | src/code-events.h » ('j') | src/code-events.h » ('J')

Powered by Google App Engine
This is Rietveld 408576698