Fix the painting problem with Stree View and Flash 10. After the size of the...

Fix the painting problem with Stree View and Flash 10.  After the size of the plugin changes, we generate a new backing store.  Flash 9 invalidates the rectangle, but Flash 10 doesn't.  As a result we paint from a blank backing store.

The fix is to keep track of which part of the backing store has been painted into by the plugin, and if the renderer tries to paint an area that falls outside of it, do a synchronous paint.

Also get rid of first_paint_, as it was introduced during a failed attempt to make plugin loading asynchronous.

Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=6128

[jam, 2008-11-27 10:21:08]

Adding correct userid, and also removed first_paint_ which isn't needed.

[ananta, 2008-11-27 21:42:04]

http://codereview.chromium.org/10792/diff/7/201
File chrome/renderer/webplugin_delegate_proxy.cc (right):

http://codereview.chromium.org/10792/diff/7/201#newcode701
Line 701: backing_store_painted_ = backing_store_painted_.Union(rect);
The rect passed in is offset based on the plugin rect, while we check in Paint
whether the backing store painted till now contains the damage rect based on its
intersection with the plugin rect. Should this code be moved to the caller?

[jam, 2008-11-28 19:55:20]

http://codereview.chromium.org/10792/diff/7/201
File chrome/renderer/webplugin_delegate_proxy.cc (right):

http://codereview.chromium.org/10792/diff/7/201#newcode701
Line 701: backing_store_painted_ = backing_store_painted_.Union(rect);
On 2008/11/27 21:42:05, ananta wrote:
> The rect passed in is offset based on the plugin rect, while we check in Paint
> whether the backing store painted till now contains the damage rect based on
its
> intersection with the plugin rect. Should this code be moved to the caller?

good catch, the code was leading to an extra sync paint.  fixed.

[ananta, 2008-11-28 22:08:08]

LGTM