Show Flash LSOs for Pepper Flash in cookie dialog.

chrome/browser/browsing_data/browsing_data_flash_lso_helper.cc

Index: chrome/browser/browsing_data/browsing_data_flash_lso_helper.cc
diff --git a/chrome/browser/browsing_data/browsing_data_flash_lso_helper.cc b/chrome/browser/browsing_data/browsing_data_flash_lso_helper.cc
new file mode 100644
index 0000000000000000000000000000000000000000..c224ecb5bf32d77c8d01311f80d9edac5a0bb3a6
--- /dev/null
+++ b/chrome/browser/browsing_data/browsing_data_flash_lso_helper.cc
@@ -0,0 +1,97 @@
+// Copyright (c) 2012 The Chromium Authors. All rights reserved.
+// Use of this source code is governed by a BSD-style license that can be
+// found in the LICENSE file.
+
+#include "chrome/browser/browsing_data/browsing_data_flash_lso_helper.h"
+
+#include <limits>
+#include <map>
+
+#include "base/callback.h"
+#include "base/logging.h"
+#include "chrome/browser/pepper_flash_settings_manager.h"
+
+namespace {
+
+class BrowsingDataFlashLSOHelperImpl

[markusheintz_, 2012/07/30 14:02:15]

Currently there is only one implementation. Do you plan to add one more
implementation for a canned version?

[Bernhard Bauer, 2012/07/31 00:20:03]

Right now content settings aren't hooked up yet to Flash, so we can't block
LSOs, nor are we notified when they're accessed. Once
http://codereview.chromium.org/10831045/ has landed, we could register
allow/block decisions in TabSpecificContentSettings though (which isn't fully
correct, as we don't get the LSO domain, but rather the URL of the swf file that
tries to access it, but it's close enough).

+    : public BrowsingDataFlashLSOHelper,
+      public PepperFlashSettingsManager::Client {
+ public:
+  explicit BrowsingDataFlashLSOHelperImpl(
+      content::BrowserContext* browser_context);
+
+  // BrowsingDataFlashLSOHelper implementation:
+  virtual void StartFetching(const GetSitesWithDataCallback& callback) OVERRIDE;
+  virtual void DeleteFlashLSOsForSite(const std::string& site) OVERRIDE;
+
+  // PepperFlashSettingsManager::Client:

[markusheintz_, 2012/07/30 14:02:15]

bike shedding: "Overridden from PepperFlash..."

[Bernhard Bauer, 2012/07/31 00:20:03]

Done.

+  virtual void OnGetSitesWithDataCompleted(
+      uint32 request_id,
+      const std::vector<std::string>& sites) OVERRIDE;
+  virtual void OnClearSiteDataCompleted(
+      uint32 request_id,
+      bool success) OVERRIDE;
+
+ private:

[markusheintz_, 2012/07/30 14:02:15]

Please document the attributes.

[Bernhard Bauer, 2012/07/31 00:20:03]

Done.

+  virtual ~BrowsingDataFlashLSOHelperImpl();
+
+  PepperFlashSettingsManager settings_manager_;
+
+  uint32 get_sites_with_data_request_id_;
+
+  std::map<uint32, std::string> clear_site_data_ids_;
+
+  GetSitesWithDataCallback callback_;

[markusheintz_, 2012/07/30 14:02:15]

Should we initialize this to NULL?

[Bernhard Bauer, 2012/07/31 00:20:03]

The default constructor for base::Callback already initializes everything to
defined values.

+
+  DISALLOW_COPY_AND_ASSIGN(BrowsingDataFlashLSOHelperImpl);
+};
+
+BrowsingDataFlashLSOHelperImpl::BrowsingDataFlashLSOHelperImpl(
+    content::BrowserContext* browser_context)
+    : ALLOW_THIS_IN_INITIALIZER_LIST(settings_manager_(this, browser_context)),
+      get_sites_with_data_request_id_(0u) {
+}
+
+BrowsingDataFlashLSOHelperImpl::~BrowsingDataFlashLSOHelperImpl() {
+}
+
+void BrowsingDataFlashLSOHelperImpl::StartFetching(
+    const GetSitesWithDataCallback& callback) {
+  DCHECK(callback_.is_null());
+  callback_ = callback;
+  get_sites_with_data_request_id_ = settings_manager_.GetSitesWithData();
+}
+
+void BrowsingDataFlashLSOHelperImpl::DeleteFlashLSOsForSite(
+    const std::string& site) {
+  const uint64 kClearAllData = 0;
+  uint32 id = settings_manager_.ClearSiteData(
+      site, kClearAllData, std::numeric_limits<uint64>::max());
+  clear_site_data_ids_[id] = site;
+}
+
+void BrowsingDataFlashLSOHelperImpl::OnGetSitesWithDataCompleted(
+    uint32 request_id,
+    const std::vector<std::string>& sites) {
+  DCHECK_EQ(get_sites_with_data_request_id_, request_id);
+  callback_.Run(sites);
+  callback_ = GetSitesWithDataCallback();
+}
+
+void BrowsingDataFlashLSOHelperImpl::OnClearSiteDataCompleted(uint32 request_id,
+                                                          bool success) {

[markusheintz_, 2012/07/30 14:02:15]

nit: Please fix indentation.

[Bernhard Bauer, 2012/07/31 00:20:03]

Done.

+  std::map<uint32, std::string>::iterator entry =
+      clear_site_data_ids_.find(request_id);
+  DCHECK(entry != clear_site_data_ids_.end());
+  LOG_IF(ERROR, !success) << "Couldn't clear Flash LSO data for "
+                          << entry->second;
+  clear_site_data_ids_.erase(entry);
+}
+
+}  // namespace
+
+// static
+BrowsingDataFlashLSOHelper* BrowsingDataFlashLSOHelper::Create(
+    content::BrowserContext* browser_context) {
+  return new BrowsingDataFlashLSOHelperImpl(browser_context);
+}