content/browser/renderer_host/media/audio_input_device_manager_unittest.cc - Issue 10790121: First step towards moving AudioDevice from content/ to media/audio.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: content/browser/renderer_host/media/audio_input_device_manager_unittest.cc

Issue 10790121: First step towards moving AudioDevice from content/ to media/audio. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: relaxing the notreached back to log(error) since nacl tests will otherwise fail Created 8 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « content/browser/renderer_host/media/audio_input_device_manager.cc ('k') | content/browser/renderer_host/media/audio_input_renderer_host.cc » ('j') | content/renderer/media/audio_input_device.cc » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: content/browser/renderer_host/media/audio_input_device_manager_unittest.cc

diff --git a/content/browser/renderer_host/media/audio_input_device_manager_unittest.cc b/content/browser/renderer_host/media/audio_input_device_manager_unittest.cc

index 257cec70777df390c88599b02e6ba7fc37b4ff66..754a649a58fdf972d07f520fce40e17fa23b8032 100644

--- a/content/browser/renderer_host/media/audio_input_device_manager_unittest.cc

+++ b/content/browser/renderer_host/media/audio_input_device_manager_unittest.cc

@@ -460,7 +460,7 @@ TEST_F(AudioInputDeviceManagerTest, StartInvalidSession) {

manager_->Start(invalid_session_id, audio_input_event_handler.get());

EXPECT_CALL(*audio_input_event_handler,

DeviceStarted(invalid_session_id,

- AudioInputDeviceManager::kInvalidDeviceId))

+ std::string()))

scherkus (not reviewing) 2012/07/24 17:57:48 nit: fits on previous line

tommi (sloooow) - chröme 2012/07/25 13:46:17 Done.

.Times(1);

message_loop_->RunAllPending();

@@ -506,7 +506,7 @@ TEST_F(AudioInputDeviceManagerTest, StartSessionTwice) {

manager_->Start(session_id, audio_input_event_handler.get());