Vboot Reference: Add kernel image verification benchmark.

Vboot Reference: Add kernel image verification benchmark.

Refactor duplicate code for the firmware image benchmark. Also fixes some functions that manipulate kernel blobs (use uint64_t instead if int).

[petkov, 2010-03-23 00:25:24]

LGTM w/ a few nits...

verify_kernel and verify_firmware sources seem very similar. Can't you share
more code between them?

http://codereview.chromium.org/1079009/diff/3001/4003
File src/platform/vboot_reference/tests/firmware_verify_benchmark.c (right):

http://codereview.chromium.org/1079009/diff/3001/4003#newcode24
src/platform/vboot_reference/tests/firmware_verify_benchmark.c:24: uint64_t
g_firmware_sizes_to_test[] = {
const?

http://codereview.chromium.org/1079009/diff/3001/4003#newcode29
src/platform/vboot_reference/tests/firmware_verify_benchmark.c:29: char*
g_firmware_size_labels[] = {
const?

http://codereview.chromium.org/1079009/diff/3001/4003#newcode34
src/platform/vboot_reference/tests/firmware_verify_benchmark.c:34: #define
NUM_SIZES_TO_TEST (sizeof(g_firmware_sizes_to_test)/ \
space before /

http://codereview.chromium.org/1079009/diff/3001/4005
File src/platform/vboot_reference/tests/kernel_verify_benchmark.c (right):

http://codereview.chromium.org/1079009/diff/3001/4005#newcode30
src/platform/vboot_reference/tests/kernel_verify_benchmark.c:30: uint64_t
g_kernel_sizes_to_test[] = {
const?

http://codereview.chromium.org/1079009/diff/3001/4005#newcode35
src/platform/vboot_reference/tests/kernel_verify_benchmark.c:35: char*
g_kernel_size_labels[] = {
const?

http://codereview.chromium.org/1079009/diff/3001/4005#newcode40
src/platform/vboot_reference/tests/kernel_verify_benchmark.c:40: #define
NUM_SIZES_TO_TEST (sizeof(g_kernel_sizes_to_test)/ \
space before /

[gauravsh, 2010-03-23 00:46:49]

As for sharing more code, I can't think of anything in particular that could be
shared - they work similarly but there are differences in the way test case
generation (and timing of the verification operation) for firmware and kernel
images. 

In any case, I will try to think of ways this could be refactored, maybe by
combining them into a single test (since it's firmware + kernel verification
time we actually care about). That's a separate CL though.

http://codereview.chromium.org/1079009/diff/3001/4003
File src/platform/vboot_reference/tests/firmware_verify_benchmark.c (right):

http://codereview.chromium.org/1079009/diff/3001/4003#newcode24
src/platform/vboot_reference/tests/firmware_verify_benchmark.c:24: uint64_t
g_firmware_sizes_to_test[] = {
On 2010/03/23 00:25:24, petkov wrote:
> const?

Done.

http://codereview.chromium.org/1079009/diff/3001/4003#newcode29
src/platform/vboot_reference/tests/firmware_verify_benchmark.c:29: char*
g_firmware_size_labels[] = {
On 2010/03/23 00:25:24, petkov wrote:
> const?
> 
Done.

http://codereview.chromium.org/1079009/diff/3001/4003#newcode34
src/platform/vboot_reference/tests/firmware_verify_benchmark.c:34: #define
NUM_SIZES_TO_TEST (sizeof(g_firmware_sizes_to_test)/ \
On 2010/03/23 00:25:24, petkov wrote:
> space before /

Done.

http://codereview.chromium.org/1079009/diff/3001/4005
File src/platform/vboot_reference/tests/kernel_verify_benchmark.c (right):

http://codereview.chromium.org/1079009/diff/3001/4005#newcode30
src/platform/vboot_reference/tests/kernel_verify_benchmark.c:30: uint64_t
g_kernel_sizes_to_test[] = {
On 2010/03/23 00:25:24, petkov wrote:
> const?
> 
Done.

http://codereview.chromium.org/1079009/diff/3001/4005#newcode35
src/platform/vboot_reference/tests/kernel_verify_benchmark.c:35: char*
g_kernel_size_labels[] = {
On 2010/03/23 00:25:24, petkov wrote:
> const?
> 

Done.

http://codereview.chromium.org/1079009/diff/3001/4005#newcode40
src/platform/vboot_reference/tests/kernel_verify_benchmark.c:40: #define
NUM_SIZES_TO_TEST (sizeof(g_kernel_sizes_to_test)/ \
On 2010/03/23 00:25:24, petkov wrote:
> space before /

Done.