[Panels refactor] Track Panels in TaskManager now that they are not under the tab contents umbrella.

chrome/browser/ui/panels/panel.cc

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "chrome/browser/ui/panels/panel.h"
 
 #include "base/logging.h"
 #include "base/message_loop.h"
 #include "base/utf_string_conversions.h"
 #include "chrome/app/chrome_command_ids.h"
@@ skipping 13 matching lines @@
 #include "content/public/browser/notification_types.h"
 #include "content/public/browser/render_view_host.h"
 #include "content/public/browser/user_metrics.h"
 #include "content/public/browser/web_contents.h"
 #include "third_party/skia/include/core/SkBitmap.h"
 #include "ui/gfx/rect.h"
 
 using content::RenderViewHost;
 using content::UserMetricsAction;
 
+namespace {
+
+static base::LazyInstance<base::PropertyAccessor<Panel*> >
+    g_panel_property_accessor = LAZY_INSTANCE_INITIALIZER;
+
+}  // namespace
+
 namespace panel_internal {
 
 class PanelExtensionWindowController : public ExtensionWindowController {
  public:
   PanelExtensionWindowController(Panel* panel, Profile* profile);
 
   // Overridden from ExtensionWindowController.
   virtual int GetWindowId() const OVERRIDE;
   virtual std::string GetWindowTypeText() const OVERRIDE;
   virtual base::DictionaryValue* CreateWindowValueWithTabs() const OVERRIDE;
@@ skipping 62 matching lines @@
 
 Panel::~Panel() {
   // Invoked by native panel destructor. Do not access native_panel_ here.
 
   // Remove shutdown prevention.
   // TODO(jennb): remove guard after refactor
   if (extension_window_controller_.get())
     browser::EndKeepAlive();
 }
 
+// static
+base::PropertyAccessor<Panel*>* Panel::property_accessor() {
+  return g_panel_property_accessor.Pointer();
+}
+
+// static
+Panel* Panel::FromWebContents(content::WebContents* contents) {
+  Panel** panel = property_accessor()->GetProperty(contents->GetPropertyBag());

[Dmitry Titov, 2012/07/18 22:52:15]

Seems a loop through PanelManager will be easier to read, smaller and not that
slow since we always have a very limited number of panels. 

+  return panel ? *panel : NULL;
+}
+
 void Panel::Initialize(const gfx::Rect& bounds, Browser* browser) {
   DCHECK(!initialized_);
   DCHECK(!panel_strip_);  // Cannot be added to a strip until fully created.
   DCHECK_EQ(EXPANDED, expansion_state_);
   DCHECK(!bounds.IsEmpty());
   initialized_ = true;
   full_size_ = bounds.size();
   native_panel_ = CreateNativePanel(browser, this, bounds);
 }
 
 void Panel::Initialize(Profile* profile, const GURL& url,
                        const gfx::Rect& bounds) {
   DCHECK(!initialized_);
   DCHECK(!panel_strip_);  // Cannot be added to a strip until fully created.
   DCHECK_EQ(EXPANDED, expansion_state_);
   DCHECK(!bounds.IsEmpty());
   initialized_ = true;
   full_size_ = bounds.size();
   native_panel_ = CreateNativePanel(this, bounds);
 
   extension_window_controller_.reset(
       new panel_internal::PanelExtensionWindowController(this, profile));
 
   InitCommandState();
 
   // Set up hosting for web contents.
   panel_host_.reset(new PanelHost(this, profile));
   panel_host_->Init(url);
-  native_panel_->AttachWebContents(GetWebContents());
+
+  // Stash this panel in the property bag so it can be retrieved without
+  // having to iterate through all panel manager.
+  content::WebContents* contents = GetWebContents();
+  if (contents) {

[Dmitry Titov, 2012/07/18 22:52:15]

can it be NULL? When?

+    property_accessor()->SetProperty(contents->GetPropertyBag(), this);
+    native_panel_->AttachWebContents(contents);
+  }
 
   // Close when the extension is unloaded or the browser is exiting.
   registrar_.Add(this, chrome::NOTIFICATION_EXTENSION_UNLOADED,
                  content::Source<Profile>(profile));
   registrar_.Add(this, content::NOTIFICATION_APP_TERMINATING,
                  content::NotificationService::AllSources());
 
   // Prevent the browser process from shutting down while this window is open.
   browser::StartKeepAlive();
 }
@@ skipping 563 matching lines @@
 
 void Panel::UpdateTitleBar() {
   native_panel_->UpdatePanelTitleBar();
 }
 
 void Panel::LoadingStateChanged(bool is_loading) {
   command_updater_.UpdateCommandEnabled(IDC_STOP, is_loading);
   native_panel_->UpdatePanelLoadingAnimations(is_loading);
   UpdateTitleBar();
 }