Add IDB perf tests for random read, with and without an index.

chrome/test/data/indexeddb/perf_shared.js

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 window.indexedDB = window.indexedDB || window.webkitIndexedDB ||
     window.mozIndexedDB || window.msIndexedDB;
 
 var automation = {
   results: {}
 };
@@ skipping 22 matching lines @@
 
 function assert(t) {
   if (!t) {
     var e = new Error("Assertion failed!");
     console.log(e.stack);
     throw e;
   }
 }
 
 function onError(e) {
-  console.log(e);
+  var s = "Caught error.";
+  if (e.target && e.target.webkitErrorMessage)
+    s += "\n" + e.target.webkitErrorMessage;
+  console.log(s);
+  automation.setStatus(s);
   e.stopPropagation();
   throw new Error(e);
 }
 
 var version = 2;  // The version with our object stores.
 var db;

[jsbell, 2012/07/26 18:23:30]

db is global here, but passed as arguments elsewhere. Consistency?

[ericu, 2012/07/26 20:24:11]

Done.

 
-function createDatabase(name, objectStores, handler, errorHandler) {
+// Valid options fields:
+//  indexName: the name of an index to create on each object store
+//  indexKeyPath: likewise
+//  indexIsUnique: the "unique" option for IDBIndexParameters
+//  indexIsMultiEntry: the "multiEntry" option for IDBIndexParameters
+//
+function createDatabase(name, objectStores, handler, errorHandler, options) {

[jsbell, 2012/07/26 18:23:30]

So, rather than special casing options for indexes, alec suggested (elsewhere)
that you could specify the whole test schema in a single JS object:

{name, 
  objectStores: opt_array[{
    name,
    autoIncrement:opt_bool,
    keyPath:opt_string_or_stringarray,
    indexes: opt_array[{
      name,
      keyPath:string_or_stringarray,
      unique:opt_bool,
      multiEntry:opt_bool
    }]
  }]
}

That doesn't help with the 'same index on every store' directly, though, if that
does prove common.

[ericu, 2012/07/26 20:24:11]

Let me think about that one for a later CL.  Depending on how complicated the
differences between the tests are, that might up with more or less total
code/mess.  It'll be easier to see which it'll be once I've got more tests in.

   var openRequest = indexedDB.open(name, version);
   openRequest.onblocked = errorHandler;
   function createObjectStores(db) {
     for (var store in objectStores) {
       var name = objectStores[store];
       assert(!db.objectStoreNames.contains(name));
-      db.createObjectStore(name);
+      var os = db.createObjectStore(name);
+      if (options && options.indexName) {
+        assert(options.indexKeyPath || options.indexKeyPath == "");

[jsbell, 2012/07/26 18:23:30]

I'd go with: assert('indexKeyPath' in options);

[ericu, 2012/07/26 20:24:11]

Much better, thanks.

+        os.createIndex(options.indexName, options.indexKeyPath,
+            { unique: options.indexIsUnique,
+              multiEntry: options.indexIsMultiEntry });
+      }
     }
   }
   openRequest.onupgradeneeded = function(ev) {
     // TODO: This is the spec-compliant path, which doesn't yet work in Chrome,
     // and isn't yet tested, as this function won't currently be called.
     assert(openRequest == ev.target);
     db = openRequest.result;
     createObjectStores(db);
     // onsuccess will get called after this exits.
   };
   openRequest.onsuccess = function(ev) {
     assert(openRequest == ev.target);
     db = openRequest.result;
     db.onerror = function(ev) {
       console.log("db error", arguments, openRequest.webkitErrorMessage);
       errorHandler();
     }

[jsbell, 2012/07/26 18:23:30]

Missing semicolon. (Sorry about the style nits on unchanged code.)

[ericu, 2012/07/26 20:24:11]

No prob; it still needs fixing.

     if (db.version != version) {
       // This is the current Chrome path.
       var setVersionRequest = db.setVersion(version);
       setVersionRequest.onfailure = errorHandler;
       setVersionRequest.onsuccess =
           function(e) {

[jsbell, 2012/07/26 18:23:30]

Put on previous line to reduce indentation on following lines.

[ericu, 2012/07/26 20:24:11]

Had to go and reread the style guide on this one; it's been a while.  Done.

             assert(setVersionRequest == e.target);
             createObjectStores(db);
             var versionTransaction = setVersionRequest.result;
             versionTransaction.oncomplete = function() {handler(db); };
             versionTransaction.onerror = onError;
           }

[jsbell, 2012/07/26 18:23:30]

Missing semicolon.

[ericu, 2012/07/26 20:24:11]

Done.

     } else {
       handler(db);
     }
   }
 }
 
 function getTransaction(db, objectStoreNames, mode, opt_handler) {
   var transaction = db.transaction(objectStoreNames, mode);
   transaction.onerror = onError;
   transaction.onabort = onError;
   if (opt_handler) {
     transaction.oncomplete = opt_handler;
   }
   return transaction;
 }
 
 function deleteDatabase(name, opt_handler) {
   var deleteRequest = indexedDB.deleteDatabase(name);
   deleteRequest.onerror = onError;
   if (opt_handler) {
     deleteRequest.onsuccess = opt_handler;
   }
 }
 
-function cleanUp(opt_handler) {
-  if (db) {
-    deleteDatabase(db, opt_handler);
-    db = null;
+function getCleanUpFunc(testName, startTime, onTestComplete) {
+  function onDeleted() {
+    automation.setStatus("Deleted database.");
+    onTestComplete();
+  }
+  return function() {
+    var duration = Date.now() - startTime;
+    // Ignore the cleanup time for this test.
+    automation.addResult(testName, duration);
+    automation.setStatus("Deleting database.");
+    // TODO: Turn on actual deletion; for now it's way too slow.
+    // deleteDatabase(testName, onDeleted);
+    onTestComplete();
   }
 }
 
 function stringOfLength(n) {
   assert(n > 0);
   assert(n == Math.floor(n));
   return new Array(n + 1).join('0');
 }