VS-Addin Build/Test/Install scripts

visual_studio/NativeClientVSAddIn/InstallerResources/install.py

+#!/usr/bin/env python
+# Copyright (c) 2012 The Chromium Authors. All rights reserved.
+# Use of this source code is governed by a BSD-style license that can be
+# found in the LICENSE file.
+
+"""Copies necessary add-in files into place to install the add-in.
+
+This script will copy the necessary files for the Visual Studio add-in
+to where Visual Studio can find them. It assumes the current directory
+contains the necessary files to copy.
+"""
+
+import os
+import platform
+import shutil
+
+if platform.system() != 'Windows':

[binji, 2012/07/17 00:05:58]

Use the standard python file structure:
http://google-styleguide.googlecode.com/svn/trunk/pyguide.html?showone=Main#Main

[tysand, 2012/07/17 01:18:18]

Done.

+        raise Exception('Must install to Windows system')

[binji, 2012/07/17 00:05:58]

2 space indent

[tysand, 2012/07/17 01:18:18]

Done.

+
+# Ensure environment variables are set
+nacl_sdk_root = os.path.expandvars('%NACL_SDK_ROOT%')

[binji, 2012/07/17 00:05:58]

just use os.getenv('NACL_SDK_ROOT', None) for this and check against None below.

[tysand, 2012/07/17 01:18:18]

Done.

+chrome_path = os.path.expandvars('%CHROME_PATH%')

[binji, 2012/07/17 00:05:58]

same here

[tysand, 2012/07/17 01:18:18]

Done.

+if nacl_sdk_root == '%NACL_SDK_ROOT%':
+        raise Exception('Environment Variable NACL_SDK_ROOT is not set')
+if chrome_path == '%CHROME_PATH%':
+        raise Exception('Environment Variable CHROME_PATH is not set')
+
+# Copy the necessary files into place
+addInDir = os.path.expandvars(
+                '%USERPROFILE%\My Documents\Visual Studio 2010\Addins')
+shutil.copy('./NativeClientVSAddIn.AddIn', addInDir)
+shutil.copy('./NativeClientVSAddIn.dll', addInDir)