Add gesture target fuzzing to views

ui/views/view.cc

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "ui/views/view.h"
 
 #include <algorithm>
 
 #include "base/debug/trace_event.h"
 #include "base/logging.h"
 #include "base/memory/scoped_ptr.h"
 #include "base/message_loop.h"
 #include "base/stringprintf.h"
 #include "base/utf_string_conversions.h"
 #include "third_party/skia/include/core/SkRect.h"
 #include "ui/base/accessibility/accessibility_types.h"
 #include "ui/base/dragdrop/drag_drop_types.h"
 #include "ui/compositor/compositor.h"
 #include "ui/compositor/layer.h"
 #include "ui/compositor/layer_animator.h"
 #include "ui/gfx/canvas.h"
 #include "ui/gfx/interpolated_transform.h"
 #include "ui/gfx/path.h"
 #include "ui/gfx/point3.h"
 #include "ui/gfx/transform.h"
 #include "ui/views/background.h"
 #include "ui/views/context_menu_controller.h"
 #include "ui/views/drag_controller.h"
 #include "ui/views/layout/layout_manager.h"
+#include "ui/views/view_constants.h"
 #include "ui/views/views_delegate.h"
 #include "ui/views/widget/native_widget_private.h"
 #include "ui/views/widget/root_view.h"
 #include "ui/views/widget/tooltip_manager.h"
 #include "ui/views/widget/widget.h"
 
 #if defined(OS_WIN)
 #include "base/win/scoped_gdi_object.h"
 #include "ui/views/accessibility/native_view_accessibility_win.h"
 #endif
@@ skipping 33 matching lines @@
 };
 
 // Returns the top view in |view|'s hierarchy.
 const views::View* GetHierarchyRoot(const views::View* view) {
   const views::View* root = view;
   while (root && root->parent())
     root = root->parent();
   return root;
 }
 
+// Returns the percentage of |rect1|'s area that is covered by |rect2|.
+float PercentCoveredBy(const gfx::Rect& rect1, const gfx::Rect& rect2) {
+  gfx::Rect intersection(rect1.Intersect(rect2));
+  float intersectionArea = intersection.width() * intersection.height();
+  float rect1Area = rect1.width() * rect1.height();
+  return intersectionArea / rect1Area;
+}

[sadrul, 2012/07/16 22:16:14]

I think this is fine ... but perhaps you could use rect.size().GetArea()

[tdanderson, 2012/07/17 19:07:07]

Done.

+
+int DistanceToInterval(int pos, int start, int end) {
+  if (pos < start)
+    return start - pos;
+  if (pos > end)
+    return end - pos;
+  return 0;
+}
+
+int DistanceSquaredFromCenterLineToPoint(const gfx::Point& point,

[sadrul, 2012/07/16 22:16:14]

document

[tdanderson, 2012/07/17 19:07:07]

Done.

+                                         const gfx::Rect& targetRect) {
+  gfx::Point centerPoint = targetRect.CenterPoint();
+  int xdist = centerPoint.x() - point.x();
+  int ydist = centerPoint.y() - point.y();
+
+  if (targetRect.width() > targetRect.height())

[sadrul, 2012/07/16 22:16:14]

braces

[rjkroege, 2012/07/16 23:35:48]

Note how WebKit != Chrome. :-)

[tdanderson, 2012/07/17 19:07:07]

Done.

[tdanderson, 2012/07/17 19:07:07]

Done.

+    xdist = DistanceToInterval(point.x(),
+                               targetRect.x() + (targetRect.height() / 2),
+                               targetRect.right() - (targetRect.height() / 2));
+  else
+    ydist = DistanceToInterval(point.y(),
+                               targetRect.y() + (targetRect.width() / 2),
+                               targetRect.bottom() - (targetRect.width() / 2));
+
+  return (xdist * xdist) + (ydist * ydist);
+}
+
 }  // namespace
 
 namespace views {
 
 // static
 ViewsDelegate* ViewsDelegate::views_delegate = NULL;
 
 // static
 const char View::kViewClassName[] = "views/View";
 
@@ skipping 1170 matching lines @@
     DCHECK_EQ(parent_layer, layer()->parent());
     parent_layer->StackAtTop(layer());
   } else {
     for (Views::const_iterator i(children_.begin()); i != children_.end(); ++i)
       (*i)->ReorderChildLayers(parent_layer);
   }
 }
 
 // Input -----------------------------------------------------------------------
 
+void View::FindClosestOverlappedRect(const gfx::Rect& touchRect,

[rjkroege, 2012/07/16 23:35:48]

This routine could conceivably explore many views. Should this be a concern?

If not noted elsewhere, return the best closestOverlappedRect, no non-const refs
in Chrome.

[tdanderson, 2012/07/17 19:07:07]

I tried to cut down the number of views explored as much as possible by only
making a recursive call on the child if the touch rect intersects the child
(otherwise this is avoided at line 1317).
Done.

+                                     gfx::Rect& closestOverlappedRect) {
+ for (int i = child_count() - 1; i >= 0; --i) {
+   View* child = child_at(i);
+
+   if (!child->visible())
+     continue;
+
+   gfx::Rect childRect(child->GetScreenBounds());

[sadrul, 2012/07/16 22:16:14]

child_rect etc.

Why ScreenBounds?

[tdanderson, 2012/07/17 19:07:07]

It seems easiest to have everything in a common coordinate system.

If closest_overlapped_rect is a pointer, then using screen bounds to describe
this rect would be necessary since we could be in different coordinate systems
at different places in the call stack.

If I changed this to a function that returned a rect instead of passing in a
pointer, it seems there would be a larger amount of overhead involved with
converting to/from child/parent coordinate systems at each recursive call as
compared to keeping everything in screen coordinates.

[sadrul, 2012/07/17 19:26:45]

This sounds reasonable. Make sure the doc for the function in view.h mentions
that the rects are in screen-coord.

[tdanderson, 2012/07/18 22:35:42]

Done.

+   if (!childRect.Intersects(touchRect))
+     continue;
+
+   if (PercentCoveredBy(childRect, touchRect) >= kFuzzingOverlapPercentage) {
+     if (closestOverlappedRect.IsEmpty()) {
+       closestOverlappedRect = childRect;
+     } else {
+       gfx::Point touchCenter(touchRect.CenterPoint());
+       int bestDistSoFar = DistanceSquaredFromCenterLineToPoint(
+           touchCenter,
+           closestOverlappedRect);
+       int curDist = DistanceSquaredFromCenterLineToPoint(touchCenter,
+                                                          childRect);
+
+       if (curDist < bestDistSoFar)
+         closestOverlappedRect = childRect;
+     }
+   }
+
+   child->FindClosestOverlappedRect(touchRect, closestOverlappedRect);
+   }

[sadrul, 2012/07/16 22:16:14]

indent is off.

[tdanderson, 2012/07/17 19:07:07]

Done.

+}
+
 bool View::HasHitTestMask() const {
   return false;
 }
 
 void View::GetHitTestMask(gfx::Path* mask) const {
   DCHECK(mask);
 }
 
 // Focus -----------------------------------------------------------------------
 
@@ skipping 822 matching lines @@
   gfx::Point widget_location(event.location());
   ConvertPointToWidget(this, &widget_location);
   GetWidget()->RunShellDrag(this, data, widget_location, drag_operations);
   return true;
 #else
   return false;
 #endif  // !defined(OS_MACOSX)
 }
 
 }  // namespace views