chrome/browser/extensions/api/extension_action/extension_actions_api.cc - Issue 10789026: Add browserAction.enable/disable as alias for pageAction.show/hide.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/extensions/api/extension_action/extension_actions_api.cc

Issue 10789026: Add browserAction.enable/disable as alias for pageAction.show/hide. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: . Created 8 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: chrome/browser/extensions/api/extension_action/extension_actions_api.cc

diff --git a/chrome/browser/extensions/api/extension_action/extension_actions_api.cc b/chrome/browser/extensions/api/extension_action/extension_actions_api.cc

index afc35db7e97c49448cb82c2dc5bf8443364e8389..4792737619d263421385199dc63ef87102cc40ec 100644

--- a/chrome/browser/extensions/api/extension_action/extension_actions_api.cc

+++ b/chrome/browser/extensions/api/extension_action/extension_actions_api.cc

@@ -91,6 +91,10 @@ bool ExtensionActionFunction::RunImpl() {

break;

}

+ case Value::TYPE_NULL:

+ // The tabId might be an optional argument.

+ break;

default:

EXTENSION_FUNCTION_VALIDATE(false);

}

« no previous file with comments | « no previous file | chrome/browser/extensions/api/extension_action/extension_browser_actions_api.h » ('j') | no next file with comments »