Expose a gpu-benchmark-only measureRecordTime API to JS. This function measures the time it takes t…

content/renderer/gpu/gpu_benchmarking_extension.cc

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "content/renderer/gpu/gpu_benchmarking_extension.h"
 #include "content/renderer/render_view_impl.h"
 #include "third_party/WebKit/Source/Platform/chromium/public/WebRenderingStats.h"
 #include "third_party/WebKit/Source/WebKit/chromium/public/WebFrame.h"
 #include "third_party/WebKit/Source/WebKit/chromium/public/WebView.h"
 #include "third_party/WebKit/Source/WebKit/chromium/public/WebFrame.h"
@@ skipping 17 matching lines @@
           "if (typeof(chrome) == 'undefined') {"
           "  chrome = {};"
           "};"
           "if (typeof(chrome.gpuBenchmarking) == 'undefined') {"
           "  chrome.gpuBenchmarking = {};"
           "};"
           "chrome.gpuBenchmarking.renderingStats = function() {"
           "  native function GetRenderingStats();"
           "  return GetRenderingStats();"
           "};"
+          "chrome.gpuBenchmarking.measureRecordTime = function(dump) {"

[nduca, 2012/07/16 22:28:40]

How about

  dumpToSkPicture = function(filename)

[alokp, 2012/07/16 22:38:09]

I chose this name because it seemed more appropriate for a class named
Benchmarking. dump/printToSkPicture is OK too.

[dmurph, 2012/07/17 00:11:54]

There's a sister patch for all rending microbenchmarks, which includes measuring
paint times to different canvases, so measuring the paint time here might be
redundant. 

+          "  dump = dump || false;"
+          "  native function MeasureRecordTime();"
+          "  return MeasureRecordTime(dump);"
+          "};"
           "chrome.gpuBenchmarking.beginSmoothScrollDown = "
           "    function(scroll_far) {"
           "  scroll_far = scroll_far || false;"
           "  native function BeginSmoothScroll();"
           "  return BeginSmoothScroll(true, scroll_far);"
           "};"
           "chrome.gpuBenchmarking.beginSmoothScrollUp = function(scroll_far) {"
           "  scroll_far = scroll_far || false;"
           "  native function BeginSmoothScroll();"
           "  return BeginSmoothScroll(false, scroll_far);"
           "};") {}
 
   virtual v8::Handle<v8::FunctionTemplate> GetNativeFunction(
       v8::Handle<v8::String> name) {
     if (name->Equals(v8::String::New("GetRenderingStats")))
       return v8::FunctionTemplate::New(GetRenderingStats);
+    if (name->Equals(v8::String::New("MeasureRecordTime")))
+      return v8::FunctionTemplate::New(MeasureRecordTime);
     if (name->Equals(v8::String::New("BeginSmoothScroll")))
       return v8::FunctionTemplate::New(BeginSmoothScroll);
 
     return v8::Handle<v8::FunctionTemplate>();
   }
 
   static v8::Handle<v8::Value> GetRenderingStats(const v8::Arguments& args) {
     WebFrame* web_frame = WebFrame::frameForEnteredContext();
     if (!web_frame)
       return v8::Undefined();
@@ skipping 10 matching lines @@
       stats_object->Set(v8::String::New("numAnimationFrames"),
                         v8::Integer::New(stats.numAnimationFrames),
                         v8::ReadOnly);
     if (stats.numFramesSentToScreen)
       stats_object->Set(v8::String::New("numFramesSentToScreen"),
                         v8::Integer::New(stats.numFramesSentToScreen),
                         v8::ReadOnly);
     return stats_object;
   }
 
+  static v8::Handle<v8::Value> MeasureRecordTime(const v8::Arguments& args) {
+    if (args.Length() != 1 || !args[0]->IsBoolean())
+      return v8::False();
+    bool dump = args[0]->BooleanValue();
+
+    WebFrame* web_frame = WebFrame::frameForEnteredContext();
+    if (!web_frame)
+      return v8::Undefined();
+
+    WebView* web_view = web_frame->view();
+    if (!web_view)
+      return v8::Undefined();
+
+    // TODO(alokp): Implement recroding time after patch for WKBUG 88271 lands.
+    double record_time = 0.0;
+    if (dump) {

[nduca, 2012/07/16 22:28:40]

I'm not sure you need to measure recording time. You're jut going to piggy back
on the measuring system since thats what we happen to have called the method...

Maybe we should rename that method to be paint()

+      // Launch file chooser dialog to select the file into which the
+      // resulting SkPicture will be dumped.

[nduca, 2012/07/16 22:28:40]

Use the filename that the script provides. The automation harness (or the user)
can put in the filename themselves, rather than having Chrome prompt

[alokp, 2012/07/16 22:38:09]

Makes it even easier. Will do.

+      // Note that for this to work Chrome needs to be launched with
+      // --no-sandbox command-line flag.
+    }
+    return v8::Number::New(record_time);
+  }
+
   static v8::Handle<v8::Value> BeginSmoothScroll(const v8::Arguments& args) {
     WebFrame* web_frame = WebFrame::frameForEnteredContext();
     if (!web_frame)
       return v8::Undefined();
 
     WebView* web_view = web_frame->view();
     if (!web_view)
       return v8::Undefined();
 
     RenderViewImpl* render_view_impl = RenderViewImpl::FromWebView(web_view);
     if (!render_view_impl)
       return v8::Undefined();
 
     if (args.Length() != 2 || !args[0]->IsBoolean() || !args[1]->IsBoolean())
       return v8::False();
 
     bool scroll_down = args[0]->BooleanValue();
     bool scroll_far = args[1]->BooleanValue();
 
     render_view_impl->BeginSmoothScroll(scroll_down, scroll_far);
     return v8::True();
   }
 };
 
 v8::Extension* GpuBenchmarkingExtension::Get() {
   return new GpuBenchmarkingWrapper();
 }
 
 }  // namespace content