Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(5274)

Unified Diff: chrome/browser/ui/password_generation_status.cc

Issue 10787023: Adding UMA stats. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Don't update histograms in the renderer. Created 8 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/ui/password_generation_status.cc
diff --git a/chrome/browser/ui/password_generation_status.cc b/chrome/browser/ui/password_generation_status.cc
new file mode 100644
index 0000000000000000000000000000000000000000..d2b8ec3be0137afe67878aed39882a6c29105cff
--- /dev/null
+++ b/chrome/browser/ui/password_generation_status.cc
@@ -0,0 +1,43 @@
+// Copyright (c) 2011 The Chromium Authors. All rights reserved.
+// Use of this source code is governed by a BSD-style license that can be
+// found in the LICENSE file.
+
+#include "chrome/browser/ui/password_generation_status.h"
+
+#include "base/metrics/histogram.h"
+
+namespace password_generation {
+
+PasswordGenerationActions::PasswordGenerationActions()
+ : learn_more_visited(false),
+ password_accepted(false),
+ password_edited(false),
+ password_regenerated(false) {
+}
+
+PasswordGenerationActions::~PasswordGenerationActions() {
+}
+
+void UpdateUserActionsHistogram(PasswordGenerationActions actions) {
+ if (actions.password_accepted) {
+ if (actions.password_edited)
+ UMA_HISTOGRAM_ENUMERATION("PasswordGeneration.UserActions",
+ ACCEPT_AFTER_EDITING, ACTION_ENUM_COUNT);
Ilya Sherman 2012/07/18 20:48:56 nit: The "UMA_HISTOGRAM_ENUMERATION" block is repe
zysxqn 2012/07/18 22:46:17 Done.
+ else
+ UMA_HISTOGRAM_ENUMERATION("PasswordGeneration.UserActions",
+ ACCEPT_ORIGINAL_PASSWORD, ACTION_ENUM_COUNT);
+ } else if (actions.learn_more_visited) {
+ UMA_HISTOGRAM_ENUMERATION("PasswordGeneration.UserActions",
+ LEARN_MORE, ACTION_ENUM_COUNT);
+ } else {
+ UMA_HISTOGRAM_ENUMERATION("PasswordGeneration.UserActions",
+ IGNORE, ACTION_ENUM_COUNT);
+ }
+}
+
+void UpdateEventsHistogram(PasswordGenerationEvent event) {
+ UMA_HISTOGRAM_ENUMERATION("PasswordGeneration.Events",
+ event, EVENT_ENUM_COUNT);
+}
+
+} // namespace password_generation

Powered by Google App Engine
This is Rietveld 408576698