Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(882)

Unified Diff: chrome/renderer/autofill/password_generation_manager_browsertest.cc

Issue 10787023: Adding UMA stats. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Fix the test. Created 8 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/renderer/autofill/password_generation_manager_browsertest.cc
diff --git a/chrome/renderer/autofill/password_generation_manager_browsertest.cc b/chrome/renderer/autofill/password_generation_manager_browsertest.cc
index 6b434e84d963f9777659bdc6778678589b5a3b0f..287823738e0b70e7de6ccb3ecb710a946946514a 100644
--- a/chrome/renderer/autofill/password_generation_manager_browsertest.cc
+++ b/chrome/renderer/autofill/password_generation_manager_browsertest.cc
@@ -7,6 +7,7 @@
#include "base/memory/scoped_ptr.h"
#include "base/memory/scoped_vector.h"
#include "base/utf_string_conversions.h"
+#include "chrome/browser/ui/password_generation_status.h"
#include "chrome/common/autofill_messages.h"
#include "chrome/renderer/autofill/password_generation_manager.h"
#include "chrome/test/base/chrome_render_view_test.h"
@@ -202,13 +203,17 @@ TEST_F(PasswordGenerationManagerTest, FillTest) {
EXPECT_TRUE(first_password_element.value().isNull());
EXPECT_TRUE(second_password_element.value().isNull());
- string16 password = ASCIIToUTF16("random_password");
- AutofillMsg_GeneratedPasswordAccepted msg(0, password);
+ password_generation::PasswordGenerationStatus status;
+ status.generated_password = "random_password";
+ status.password_accepted = true;
+ AutofillMsg_PasswordGenerationBubbleClosed msg(0, status);
generation_manager_->OnMessageReceived(msg);
// Password fields are filled out and set as being autofilled.
- EXPECT_EQ(password, first_password_element.value());
- EXPECT_EQ(password, second_password_element.value());
+ EXPECT_EQ(ASCIIToUTF16(status.generated_password),
+ first_password_element.value());
+ EXPECT_EQ(ASCIIToUTF16(status.generated_password),
+ second_password_element.value());
EXPECT_TRUE(first_password_element.isAutofilled());
EXPECT_TRUE(second_password_element.isAutofilled());

Powered by Google App Engine
This is Rietveld 408576698