Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1975)

Unified Diff: chrome/browser/password_manager/password_manager.cc

Issue 10787023: Adding UMA stats. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Created 8 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/password_manager/password_manager.cc
diff --git a/chrome/browser/password_manager/password_manager.cc b/chrome/browser/password_manager/password_manager.cc
index 7885d2196f61186cc4e0b259c66df86dbb61658c..3a516c30ddfb80fadd466e69806ddbc4c3fbac6a 100644
--- a/chrome/browser/password_manager/password_manager.cc
+++ b/chrome/browser/password_manager/password_manager.cc
@@ -4,6 +4,7 @@
#include "chrome/browser/password_manager/password_manager.h"
+#include "base/metrics/histogram.h"
#include "base/threading/platform_thread.h"
#include "base/utf_string_conversions.h"
#include "chrome/browser/password_manager/password_form_manager.h"
@@ -97,7 +98,6 @@ void PasswordManager::SetFormHasGeneratedPassword(const PasswordForm& form) {
ssl_valid);
pending_login_managers_.push_back(manager);
manager->SetHasGeneratedPassword();
- // TODO(gcasto): Add UMA stats to track this.
Garrett Casto 2012/07/16 22:32:39 This comment was meant for this particular case, s
zysxqn 2012/07/18 01:01:00 Oops, misunderstood your meaning here. Put it back
}
bool PasswordManager::IsSavingEnabled() const {
@@ -239,6 +239,8 @@ void PasswordManager::OnPasswordFormsRendered(
// given consent, either through previously accepting the infobar or by having
// the browser generate the password.
provisional_save_manager_->SubmitPassed();
+ if (provisional_save_manager_->HasGeneratedPassword())
+ UMA_HISTOGRAM_COUNTS("PasswordGeneration.GeneratedPasswordSubmitted", 1);
if (provisional_save_manager_->IsNewLogin() &&
!provisional_save_manager_->HasGeneratedPassword()) {
delegate_->AddSavePasswordInfoBarIfPermitted(

Powered by Google App Engine
This is Rietveld 408576698