Adding UMA stats.

chrome/renderer/autofill/password_generation_manager.cc

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "chrome/renderer/autofill/password_generation_manager.h"
 
 #include "base/logging.h"
+#include "base/metrics/histogram.h"
+#include "base/utf_string_conversions.h"
+#include "chrome/browser/ui/password_generation_status.h"
 #include "chrome/common/autofill_messages.h"
 #include "chrome/common/net/gaia/gaia_urls.h"
 #include "content/public/renderer/render_view.h"
 #include "third_party/WebKit/Source/WebKit/chromium/public/WebDocument.h"
 #include "third_party/WebKit/Source/WebKit/chromium/public/WebInputElement.h"
 #include "third_party/WebKit/Source/WebKit/chromium/public/WebFormElement.h"
 #include "third_party/WebKit/Source/WebKit/chromium/public/WebFrame.h"
 #include "third_party/WebKit/Source/WebKit/chromium/public/WebSecurityOrigin.h"
 #include "third_party/WebKit/Source/WebKit/chromium/public/WebView.h"
 #include "third_party/WebKit/Source/WebKit/chromium/public/platform/WebCString.h"
 #include "third_party/WebKit/Source/WebKit/chromium/public/platform/WebRect.h"
 #include "third_party/WebKit/Source/WebKit/chromium/public/platform/WebVector.h"
 #include "ui/gfx/rect.h"
 
+using namespace password_generation;

[Ilya Sherman, 2012/07/18 05:36:15]

"using namespace" is disallowed by the Chromium style guide

[zysxqn, 2012/07/18 19:16:46]

Done.

+
 namespace autofill {
 
 namespace {
 
 // Returns true if we think that this form is for account creation. |passwords|
 // is filled with the password field(s) in the form.
 bool GetAccountCreationPasswordFields(
     const WebKit::WebFormElement& form,
     std::vector<WebKit::WebInputElement>* passwords) {
   // Grab all of the passwords for the form.
@@ skipping 76 matching lines @@
 
     // Do not generate password for GAIA since it is used to retrieve the
     // generated paswords.
     GURL realm(password_form->signon_realm);
     if (realm == GURL(GaiaUrls::GetInstance()->gaia_login_form_realm()))
       continue;
 
     std::vector<WebKit::WebInputElement> passwords;
     if (GetAccountCreationPasswordFields(forms[i], &passwords)) {
       DVLOG(2) << "Account creation form detected";
+      UMA_HISTOGRAM_ENUMERATION("PasswordGeneration.Events",
+                                SIGN_UP_DETECTED, EVENT_ENUM_COUNT);
       passwords_ = passwords;
       account_creation_form_origin_ = password_form->origin;
       MaybeShowIcon();
       // We assume that there is only one account creation field per URL.
       return;
     }
   }
 }
 
 bool PasswordGenerationManager::ShouldAnalyzeDocument(
@@ skipping 33 matching lines @@
 void PasswordGenerationManager::handleClick(WebKit::WebInputElement& element) {
   gfx::Rect rect(element.decorationElementFor(this).boundsInViewportSpace());
   webkit::forms::PasswordForm* password_form(
       webkit::forms::PasswordFormDomManager::CreatePasswordForm(
           element.form()));
   if (password_form) {
     Send(new AutofillHostMsg_ShowPasswordGenerationPopup(routing_id(),
                                                          rect,
                                                          element.maxLength(),
                                                          *password_form));
+    UMA_HISTOGRAM_ENUMERATION("PasswordGeneration.Events",
+                              BUBBLE_SHOWN, EVENT_ENUM_COUNT);
   }
 }
 
 void PasswordGenerationManager::willDetach(
     const WebKit::WebInputElement& element) {
   // No implementation
 }
 
 bool PasswordGenerationManager::OnMessageReceived(const IPC::Message& message) {
   bool handled = true;
   IPC_BEGIN_MESSAGE_MAP(PasswordGenerationManager, message)
     IPC_MESSAGE_HANDLER(AutofillMsg_FormNotBlacklisted,
                         OnFormNotBlacklisted)
-    IPC_MESSAGE_HANDLER(AutofillMsg_GeneratedPasswordAccepted,
-                        OnPasswordAccepted)
+    IPC_MESSAGE_HANDLER(AutofillMsg_PasswordGenerationBubbleClosed,
+                        OnPasswordGenerationBubbleClosed)
     IPC_MESSAGE_HANDLER(AutofillMsg_PasswordGenerationEnabled,
                         OnPasswordGenerationEnabled)
     IPC_MESSAGE_UNHANDLED(handled = false)
   IPC_END_MESSAGE_MAP()
   return handled;
 }
 
 void PasswordGenerationManager::OnFormNotBlacklisted(
     const webkit::forms::PasswordForm& form) {
   not_blacklisted_password_form_origins_.push_back(form.origin);
   MaybeShowIcon();
 }
 
-void PasswordGenerationManager::OnPasswordAccepted(const string16& password) {
-  for (std::vector<WebKit::WebInputElement>::iterator it = passwords_.begin();
+void PasswordGenerationManager::OnPasswordGenerationBubbleClosed(
+    const PasswordGenerationStatus& status) {
+  if (status.password_accepted) {
+    if (status.password_edited)
+      UMA_HISTOGRAM_ENUMERATION("PasswordGeneration.UserActions",
+                                ACCEPT_AFTER_EDITING, ACTION_ENUM_COUNT);
+    else
+      UMA_HISTOGRAM_ENUMERATION("PasswordGeneration.UserActions",
+                                ACCEPT_ORIGINAL_PASSWORD, ACTION_ENUM_COUNT);
+    for (std::vector<WebKit::WebInputElement>::iterator it = passwords_.begin();
        it != passwords_.end(); ++it) {
-    it->setValue(password);
-    it->setAutofilled(true);
-    // Advance focus to the next input field. We assume password fields in
-    // an account creation form are always adjacent.
-    render_view_->GetWebView()->advanceFocus(false);
+      it->setValue(UTF8ToUTF16(status.generated_password));
+      it->setAutofilled(true);
+      // Advance focus to the next input field. We assume password fields in
+      // an account creation form are always adjacent.
+      render_view_->GetWebView()->advanceFocus(false);
+    }
+  } else if (status.learn_more_visited) {
+    UMA_HISTOGRAM_ENUMERATION("PasswordGeneration.UserActions",
+                              LEARN_MORE, ACTION_ENUM_COUNT);
+  } else {
+    UMA_HISTOGRAM_ENUMERATION("PasswordGeneration.UserActions",
+                              IGNORE, ACTION_ENUM_COUNT);
   }
 }
 
 void PasswordGenerationManager::OnPasswordGenerationEnabled(bool enabled) {
   enabled_ = enabled;
 }
 
 void PasswordGenerationManager::MaybeShowIcon() {
   // We should show the password generation icon only when we have detected
   // account creation form and we have confirmed from browser that this form
   // is not blacklisted by the users.
   if (!account_creation_form_origin_.is_valid() ||
       passwords_.empty() ||
       not_blacklisted_password_form_origins_.empty()) {
     return;
   }
 
   for (std::vector<GURL>::iterator it =
            not_blacklisted_password_form_origins_.begin();
        it != not_blacklisted_password_form_origins_.end(); ++it) {
     if (*it == account_creation_form_origin_) {
       passwords_[0].decorationElementFor(this).setAttribute("style",
                                                             "display:block");
+      UMA_HISTOGRAM_ENUMERATION("PasswordGeneration.Events",
+                                ICON_SHOWN, EVENT_ENUM_COUNT);
       return;
     }
   }
 }
 
 }  // namespace autofill