Adding UMA stats.

chrome/browser/ui/gtk/password_generation_bubble_gtk.cc

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "chrome/browser/ui/gtk/password_generation_bubble_gtk.h"
 
+#include "base/metrics/histogram.h"
 #include "base/utf_string_conversions.h"
 #include "chrome/browser/autofill/password_generator.h"
 #include "chrome/browser/password_manager/password_manager.h"
 #include "chrome/browser/ui/browser.h"
 #include "chrome/browser/ui/browser_finder.h"
 #include "chrome/browser/ui/gtk/bubble/bubble_gtk.h"
 #include "chrome/browser/ui/gtk/gtk_chrome_link_button.h"
 #include "chrome/browser/ui/gtk/gtk_theme_service.h"
 #include "chrome/browser/ui/gtk/gtk_util.h"
 #include "chrome/browser/ui/tab_contents/tab_contents.h"
@@ skipping 70 matching lines @@
 
   bubble_ = BubbleGtk::Show(tab->web_contents()->GetContentNativeView(),
                             &anchor_rect,
                             content,
                             BubbleGtk::ARROW_LOCATION_TOP_LEFT,
                             BubbleGtk::MATCH_SYSTEM_THEME |
                                 BubbleGtk::POPUP_WINDOW |
                                 BubbleGtk::GRAB_INPUT,
                             GtkThemeService::GetFrom(tab_->profile()),
                             NULL);  // delegate
+  UMA_HISTOGRAM_COUNTS(
+      "PasswordGeneration.PasswordGenerationBubbleShown_Linux", 1);

[Garrett Casto, 2012/07/16 22:32:39]

You can break down UMA stats by OS so you don't need to encode that information
in the stat name.

[zysxqn, 2012/07/18 01:01:00]

Done.

 
   g_signal_connect(content, "destroy",
                    G_CALLBACK(&OnDestroyThunk), this);
   g_signal_connect(accept_button, "clicked",
                    G_CALLBACK(&OnAcceptClickedThunk), this);
   g_signal_connect(text_field_, "icon-press",
                    G_CALLBACK(&OnRegenerateClickedThunk), this);
+  g_signal_connect(text_field_, "changed",
+                   G_CALLBACK(&OnPasswordEditedThunk), this);
   g_signal_connect(learn_more_link, "clicked",
                    G_CALLBACK(OnLearnMoreLinkClickedThunk), this);
 }
 
 PasswordGenerationBubbleGtk::~PasswordGenerationBubbleGtk() {}
 
 void PasswordGenerationBubbleGtk::OnDestroy(GtkWidget* widget) {
   // We are self deleting, we have a destroy signal setup to catch when we are
   // destroyed (via the BubbleGtk being destroyed), and delete ourself.
   delete this;
 }
 
 void PasswordGenerationBubbleGtk::OnAcceptClicked(GtkWidget* widget) {
+  UMA_HISTOGRAM_COUNTS("PasswordGeneration.PasswordAccepted", 1);
   RenderViewHost* render_view_host = tab_->web_contents()->GetRenderViewHost();
   render_view_host->Send(new AutofillMsg_GeneratedPasswordAccepted(
       render_view_host->GetRoutingID(),
       UTF8ToUTF16(gtk_entry_get_text(GTK_ENTRY(text_field_)))));
   tab_->password_manager()->SetFormHasGeneratedPassword(form_);
   bubble_->Close();
 }
 
 void PasswordGenerationBubbleGtk::OnRegenerateClicked(
     GtkWidget* widget,
     GtkEntryIconPosition icon_pos,
     GdkEvent* event) {
+  UMA_HISTOGRAM_COUNTS("PasswordGeneration.RegenerationButtonClicked", 1);
   gtk_entry_set_text(GTK_ENTRY(text_field_),
                      password_generator_->Generate().c_str());
 }
 
+void PasswordGenerationBubbleGtk::OnPasswordEdited(GtkWidget* widget) {
+  UMA_HISTOGRAM_COUNTS("PasswordGeneration.PasswordEditedByUsers", 1);

[Garrett Casto, 2012/07/16 22:32:39]

I would think that we would want to know if the password had been edited when
it's submitted, not how many times it's been edited. So have this function
simply set a boolean and read it during OnAcceptClicked and possibly increment
the count.

[zysxqn, 2012/07/18 01:01:00]

Done.

+}
+
 void PasswordGenerationBubbleGtk::OnLearnMoreLinkClicked(GtkButton* button) {
+  UMA_HISTOGRAM_COUNTS("PasswordGeneration.LearnMoreLinkClicked", 1);
   Browser* browser = browser::FindBrowserWithWebContents(tab_->web_contents());
   content::OpenURLParams params(
       GURL(chrome::kAutoPasswordGenerationLearnMoreURL), content::Referrer(),
       NEW_FOREGROUND_TAB, content::PAGE_TRANSITION_LINK, false);
   browser->OpenURL(params);
   bubble_->Close();
 }