Refactored SettingsFrontend and forwarding of calls to the backends.

chrome/browser/extensions/settings/settings_namespace.cc

Index: chrome/browser/extensions/settings/settings_namespace.cc
diff --git a/chrome/browser/extensions/settings/settings_namespace.cc b/chrome/browser/extensions/settings/settings_namespace.cc
index 7340592468da90ee157d7b3831468f5d26225662..245390e300dd709fd5b65efc7091d9672fe35202 100644
--- a/chrome/browser/extensions/settings/settings_namespace.cc
+++ b/chrome/browser/extensions/settings/settings_namespace.cc
@@ -11,14 +11,16 @@ namespace extensions {
 namespace settings_namespace {
 
 namespace {
-const char* kLocalNamespace = "local";
-const char* kSyncNamespace  = "sync";
+const char kLocalNamespace[] = "local";
+const char kSyncNamespace[]  = "sync";
+const char kManagedNamespace[] = "managed";
 }  // namespace
 
 std::string ToString(Namespace settings_namespace) {
   switch (settings_namespace) {
-    case LOCAL: return kLocalNamespace;
-    case SYNC:  return kSyncNamespace;
+    case LOCAL:   return kLocalNamespace;
+    case SYNC:    return kSyncNamespace;
+    case MANAGED: return kManagedNamespace;
     case INVALID:
     default: NOTREACHED();

[not at google - send to devlin, 2012/07/18 07:46:18]

nit (to myself! oh well) no default branch, prevents the compiler from picking
up on errors like this. NOTREACHED() before the "return std::string()" at the
end though.

[Joao da Silva, 2012/07/18 21:40:25]

Done.

   }
@@ -30,6 +32,8 @@ Namespace FromString(const std::string& namespace_string) {
     return LOCAL;
   else if (namespace_string == kSyncNamespace)
     return SYNC;
+  else if (namespace_string == kManagedNamespace)

[not at google - send to devlin, 2012/07/18 07:46:18]

nit, also to myself: remove the "else"s

[Joao da Silva, 2012/07/18 21:40:25]

Also done.

+    return MANAGED;
   return INVALID;
 }