screenshot disabling policy tests

chrome/test/functional/policy.py

 #!/usr/bin/env python
 # Copyright (c) 2012 The Chromium Authors. All rights reserved.
 # Use of this source code is governed by a BSD-style license that can be
 # found in the LICENSE file.
 
 import logging
 import os
 
 import pyauto_functional  # must come before pyauto.
 import policy_base
@@ skipping 670 matching lines @@
 
     # With the policy set, the cookie should be gone after a restart.
     self.SetUserPolicy({
       'ClearSiteDataOnExit': True
     })
     self.RestartBrowser(clear_profile=False)
     self.assertFalse(
         self.GetCookie(pyauto.GURL(cookie_url)),
         msg='Cookie present on ' + cookie_url + '.');
 
+  def testDisableScreenshotFile(self):

[Nirnimesh, 2012/07/16 20:01:50]

one-line docstring please

[qfel, 2012/07/17 10:07:25]

Done.

+    if not self.IsChromeOS():
+      return  # Screenshot accelerator available only on ChromeOS
+
+    TAKE_SCREENSHOT = 34  # See AcceleratorAction enum in accelerator_table.h

[Nirnimesh, 2012/07/16 20:01:50]

This seems bad. Can you try to swig out the accelerator_table.h file?
See how chrome/app/chrome_command_ids.h is swigged out in
chrome/test/pyautolib/pyautolib.i

[qfel, 2012/07/17 10:07:25]

Done.

+
+    def files_count():
+      return len(os.listdir(download_dir))

[Nirnimesh, 2012/07/16 20:01:50]

It's bad to have a function use vars defined after the function. It's a
one-liner anyway. please choose one of:
1. get rid of the function
2. define the function after the var (or define a lamda) 

[qfel, 2012/07/17 10:07:25]

Done.

+
+    download_dir = self.GetDownloadDirectory().value()
+    original_count = files_count()
+
+    # Make sure screenshots actually go to downloads directory.
+    self.assertTrue(self.ApplyAshAccelerator(TAKE_SCREENSHOT))
+    self.assertTrue(self.WaitUntil(files_count,
+                                   expect_retval=original_count + 1))
+
+    # Real testing here: check if disabling screenshots works.
+    policy = {
+      'DisableScreenshots': True
+    }
+    self.SetUserPolicy(policy)
+    self.assertTrue(self.ApplyAshAccelerator(TAKE_SCREENSHOT))
+    self.assertFalse(self.WaitUntil(lambda: files_count() != original_count + 1,
+                                    timeout=5, expect_retval=True))

[Mattias Nissler (ping if slow), 2012/07/16 10:51:55]

nirnimesh: I'm unhappy with these timeouts, but essentially we're waiting for
nothing to happen here. Any suggestions on how to improve this?

[Nirnimesh, 2012/07/16 20:01:50]

Unfortunately, I don't have a good solution for this problem.
We avoid using assertFalse with WaitUntil, for this very reason.
Instead, is it possible to get a notification back from the browser when the
accelerator has been handled completely?

[qfel, 2012/07/17 10:07:25]

The accelerator is always considered handled. Its handler returns when saving of
screenshot has been posted to the file thread (or grabbing the screenshot
failed).
Perhaps we could sync with file thread and see if the file appears afterwards,
if you do not fear depending on implementation details (eg. just posting a
blocking job to the file thread).

+
+  def testDisableScreenshotFeedback(self):

[Nirnimesh, 2012/07/16 20:01:50]

docstring please

[qfel, 2012/07/17 10:07:25]

Done.

+    # Make sure screenshot is normally displayed in feedback form.
+    self.assertTrue(self.ApplyAccelerator(pyauto.IDC_FEEDBACK))
+    self.WaitUntilNavigationCompletes(tab_index=1)

[Nirnimesh, 2012/07/16 20:01:50]

you might want to wait for tab count to become 2 before this

[qfel, 2012/07/17 10:07:25]

Done.

+    self.WaitForDomNode('//img[starts-with(@id, "current-screenshots")]',
+                        tab_index=1)
+
+    # The feedback tab is a singleton tab, so close it first before trying to
+    # reopen. Otherwise it might not reload.
+    self.GetBrowserWindow(0).GetTab(1).Close(True)
+
+    # Real testing here: check if disabling screenshots works.
+    policy = {
+      'DisableScreenshots': True
+    }
+    self.SetUserPolicy(policy)
+    self.assertTrue(self.ApplyAccelerator(pyauto.IDC_FEEDBACK))
+    self.WaitUntilNavigationCompletes(tab_index=1)
+    self.assertRaises(pyauto.JSONInterfaceError, lambda: self.WaitForDomNode(
+        '//img[starts-with(@id, "current-screenshots")]', tab_index=1,
+        timeout=3))
+
 
 if __name__ == '__main__':
   pyauto_functional.Main()